@@ -39,19 +39,6 @@ bool RequestSendHandler::Handle(const std::string& varname,
39
39
const std::string& out_var_name) {
40
40
VLOG (4 ) << " RequestSendHandler:" << varname;
41
41
42
- // Async
43
- if (!sync_mode_) {
44
- rpc_server_->Profiler ().OneStep ();
45
- try {
46
- executor_->RunPreparedContext ((*grad_to_prepared_ctx_)[varname].get (),
47
- scope);
48
- } catch (std::exception& e) {
49
- LOG (ERROR) << " async: run sub program error " << e.what ();
50
- return false ;
51
- }
52
- return true ;
53
- }
54
-
55
42
// Sync
56
43
if (varname == BATCH_BARRIER_MESSAGE) {
57
44
VLOG (3 ) << " sync: recv BATCH_BARRIER_MESSAGE" ;
@@ -60,17 +47,31 @@ bool RequestSendHandler::Handle(const std::string& varname,
60
47
VLOG (3 ) << " sync: recv complete message" ;
61
48
rpc_server_->Complete ();
62
49
} else {
63
- VLOG (3 ) << " sync: received var_name: " << varname;
64
- rpc_server_->WaitCond (kRequestSend );
65
- VLOG (3 ) << " sync: processing received var: " << varname;
66
-
67
- if (invar == nullptr ) {
68
- LOG (FATAL) << " sync: Can not find server side var: " << varname;
69
- return false ;
70
- }
71
- if (invar->IsType <framework::SelectedRows>()) {
72
- std::unique_lock<std::mutex> lock (mutex_sparse_vars_);
73
- sparse_vars_.push_back (invar);
50
+ // Async
51
+ if (!sync_mode_) {
52
+ VLOG (3 ) << " async process var: " << varname;
53
+ rpc_server_->Profiler ().OneStep ();
54
+ try {
55
+ executor_->RunPreparedContext ((*grad_to_prepared_ctx_)[varname].get (),
56
+ scope);
57
+ } catch (std::exception& e) {
58
+ LOG (ERROR) << " async: run sub program error " << e.what ();
59
+ return false ;
60
+ }
61
+ return true ;
62
+ } else { // sync
63
+ rpc_server_->WaitCond (kRequestSend );
64
+ VLOG (3 ) << " sync: processing received var: " << varname;
65
+
66
+ if (invar == nullptr ) {
67
+ LOG (FATAL) << " sync: Can not find server side var: " << varname;
68
+ return false ;
69
+ }
70
+
71
+ if (invar->IsType <framework::SelectedRows>()) {
72
+ std::unique_lock<std::mutex> lock (mutex_sparse_vars_);
73
+ sparse_vars_.push_back (invar);
74
+ }
74
75
}
75
76
}
76
77
return true ;
0 commit comments