Skip to content

Commit 7f868bd

Browse files
authored
Merge pull request #15737 from tensor-tang/fix/name
cherry pick: fix jitcode name
2 parents cfa546c + 396ba93 commit 7f868bd

File tree

9 files changed

+18
-18
lines changed

9 files changed

+18
-18
lines changed

paddle/fluid/operators/jit/gen/act.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ class VActFunc : public JitCode {
6363
public:
6464
explicit VActFunc(size_t code_size, void* code_ptr)
6565
: JitCode(code_size, code_ptr) {}
66-
virtual const char* name() const = 0;
6766
virtual void genCode() = 0;
6867

6968
protected:
@@ -269,7 +268,7 @@ class VActJitCode : public VActFunc {
269268
this->genCode();
270269
}
271270

272-
const char* name() const override {
271+
std::string name() const override {
273272
std::string base = "VActJitCode";
274273
switch (type_) {
275274
case operand_type::RELU:
@@ -293,7 +292,7 @@ class VActJitCode : public VActFunc {
293292
default:
294293
break;
295294
}
296-
return base.c_str();
295+
return base;
297296
}
298297
void genCode() override;
299298

paddle/fluid/operators/jit/gen/blas.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class VXXJitCode : public JitCode {
4141
this->genCode();
4242
}
4343

44-
virtual const char* name() const {
44+
std::string name() const override {
4545
std::string base = "VXXJitCode";
4646
if (scalar_index_ == 1) {
4747
base += "_Scalar";
@@ -62,7 +62,7 @@ class VXXJitCode : public JitCode {
6262
}
6363
base += (with_relu_ ? "_Relu" : "");
6464
base += "_D" + std::to_string(num_);
65-
return base.c_str();
65+
return base;
6666
}
6767
void genCode() override;
6868

paddle/fluid/operators/jit/gen/gru.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class GRUJitCode : public VActFunc {
4949
this->genCode();
5050
}
5151

52-
const char* name() const override {
52+
std::string name() const override {
5353
std::string base = "GRUJitCode";
5454
if (id_ == 0) {
5555
base += "_H1";
@@ -81,7 +81,7 @@ class GRUJitCode : public VActFunc {
8181
};
8282
AddTypeStr(act_gate_);
8383
AddTypeStr(act_cand_);
84-
return base.c_str();
84+
return base;
8585
}
8686
void genCode() override;
8787

paddle/fluid/operators/jit/gen/hopv.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,14 @@ class HOPVJitCode : public JitCode {
3535
this->genCode();
3636
}
3737

38-
virtual const char* name() const {
38+
std::string name() const override {
3939
std::string base = "VXXJitCode";
4040
if (type_ == operand_type::MAX) {
4141
base += "_MAX";
4242
} else {
4343
base += "_SUM";
4444
}
45-
return base.c_str();
45+
return base;
4646
}
4747
void genCode() override;
4848

paddle/fluid/operators/jit/gen/jitcode.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
#pragma once
1616

17+
#include <string>
1718
#include <type_traits>
1819
#include "paddle/fluid/operators/jit/gen_base.h"
1920
#include "paddle/fluid/platform/cpu_info.h"
@@ -59,7 +60,7 @@ typedef enum {
5960
} operand_type;
6061

6162
#define DECLARE_JIT_CODE(codename) \
62-
const char* name() const override { return #codename; }
63+
std::string name() const override { return #codename; }
6364

6465
class JitCode : public GenBase, public Xbyak::CodeGenerator {
6566
public:
@@ -68,7 +69,6 @@ class JitCode : public GenBase, public Xbyak::CodeGenerator {
6869
(code_size % 4096 != 0 ? (code_size / 4096 + 1) * 4096 : code_size),
6970
code_ptr) {}
7071

71-
virtual const char* name() const = 0;
7272
virtual void genCode() = 0;
7373

7474
size_t getSize() const override { return CodeGenerator::getSize(); }

paddle/fluid/operators/jit/gen/lstm.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class LSTMJitCode : public VActFunc {
5353
this->genCode();
5454
}
5555

56-
const char* name() const override {
56+
std::string name() const override {
5757
std::string base = "LSTMJitCode";
5858
if (use_peephole_) {
5959
base += "_Peephole";
@@ -85,7 +85,7 @@ class LSTMJitCode : public VActFunc {
8585
AddTypeStr(act_gate_);
8686
AddTypeStr(act_cand_);
8787
AddTypeStr(act_cell_);
88-
return base.c_str();
88+
return base;
8989
}
9090
void genCode() override;
9191

paddle/fluid/operators/jit/gen/matmul.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ class MatMulJitCode : public JitCode {
3636
this->genCode();
3737
}
3838

39-
virtual const char* name() const {
39+
std::string name() const override {
4040
std::string base = "MatMulJitCode";
4141
base = base + "_M" + std::to_string(m_) + "_N" + std::to_string(n_) + "_K" +
4242
std::to_string(k_);
43-
return base.c_str();
43+
return base;
4444
}
4545
void genCode() override;
4646

paddle/fluid/operators/jit/gen/seqpool.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class SeqPoolJitCode : public JitCode {
3838
this->genCode();
3939
}
4040

41-
virtual const char* name() const {
41+
std::string name() const override {
4242
std::string base = "SeqPoolJitCode";
4343
if (type_ == SeqPoolType::kSum) {
4444
base += "_Sum";
@@ -48,7 +48,7 @@ class SeqPoolJitCode : public JitCode {
4848
base += "_Sqrt";
4949
}
5050
base += ("_W" + std::to_string(w_));
51-
return base.c_str();
51+
return base;
5252
}
5353
void genCode() override;
5454

paddle/fluid/operators/jit/gen_base.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
#include <gflags/gflags.h>
1818
#include <memory> // for unique_ptr
19+
#include <string>
1920
#include <vector>
2021
#include "paddle/fluid/operators/jit/kernel_base.h"
2122

@@ -28,7 +29,7 @@ namespace jit {
2829
class GenBase : public Kernel {
2930
public:
3031
virtual ~GenBase() = default;
31-
virtual const char* name() const = 0;
32+
virtual std::string name() const = 0;
3233
virtual size_t getSize() const = 0;
3334
virtual const unsigned char* getCodeInternal() = 0;
3435
template <typename Func>

0 commit comments

Comments
 (0)