@@ -508,20 +508,20 @@ function assert_api_spec_approvals() {
508
508
echo " checking ${API_FILE} change, PR: ${GIT_PR_ID} , changes: ${API_CHANGE} "
509
509
if [ " ${API_CHANGE} " ] && [ " ${GIT_PR_ID} " != " " ]; then
510
510
# NOTE: per_page=10000 should be ok for all cases, a PR review > 10000 is not human readable.
511
- # approval_user_list: XiaoguangHu01 46782768,chengduoZH 30176695,Xreki 12538138,luotao1 6836917,sneaxiy 32832641,tensor-tang 21351065,jacquesqiao 3048612,xsrobin 50069408 qingqing01 7845005.
511
+ # approval_user_list: XiaoguangHu01 46782768,chengduoZH 30176695,Xreki 12538138,luotao1 6836917,sneaxiy 32832641,tensor-tang 21351065,jacquesqiao 3048612,xsrobin 50069408,qingqing01 7845005,junjun315 3124479,shanyi15 35982308.
512
+ approval_line=` curl -H " Authorization: token ${GITHUB_API_TOKEN} " https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID} /reviews? per_page=10000`
512
513
if [ " ${API_FILE} " == " paddle/fluid/API.spec" ]; then
513
- APPROVALS=` curl -H " Authorization: token ${GITHUB_API_TOKEN} " https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID} /reviews? per_page=10000 | \
514
- python ${PADDLE_ROOT} /tools/check_pr_approval.py 2 50069408 46782768 30176695 6836917 7845005`
514
+ APPROVALS=` echo ${approval_line} | python ${PADDLE_ROOT} /tools/check_pr_approval.py 1 46782768 30176695 6836917 7845005`
515
515
if [ " ${APPROVALS} " == " TRUE" ]; then
516
- APPROVALS=` curl -H " Authorization: token ${GITHUB_API_TOKEN} " https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID} /reviews? per_page=10000 | \
517
- python ${PADDLE_ROOT} /tools/check_pr_approval.py 1 50069408`
516
+ APPROVALS=` echo ${approval_line} | python ${PADDLE_ROOT} /tools/check_pr_approval.py 1 50069408 35982308`
518
517
fi
519
518
elif [ " ${API_FILE} " == " CMakeLists.txt" ]; then
520
519
APPROVALS=` curl -H " Authorization: token ${GITHUB_API_TOKEN} " https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID} /reviews? per_page=10000 | \
521
520
python ${PADDLE_ROOT} /tools/check_pr_approval.py 1 6836917 46782768 30176695`
522
521
elif [ " ${API_FILE} " == " python/paddle/fluid/__init__.py" ]; then
523
- APPROVALS=` curl -H " Authorization: token ${GITHUB_API_TOKEN} " https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID} /reviews? per_page=10000 | \
524
- python ${PADDLE_ROOT} /tools/check_pr_approval.py 1 50069408`
522
+ APPROVALS=` echo ${approval_line} | python ${PADDLE_ROOT} /tools/check_pr_approval.py 1 50069408 35982308`
523
+ elif [ " ${API_FILE} " == " python/requirements.txt" ]; then
524
+ APPROVALS=` echo ${approval_line} | python ${PADDLE_ROOT} /tools/check_pr_approval.py 1 3124479 6836917`
525
525
else
526
526
APPROVALS=` curl -H " Authorization: token ${GITHUB_API_TOKEN} " https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID} /reviews? per_page=10000 | \
527
527
python ${PADDLE_ROOT} /tools/check_pr_approval.py 1 21351065 3048612 46782768 30176695 12538138 6836917 32832641`
0 commit comments