Skip to content

Commit 997e8b9

Browse files
yi.wutyphoonzero
authored andcommitted
fix term core only
1 parent e5fc9a1 commit 997e8b9

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

cmake/external/grpc.cmake

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,18 @@ ELSE()
3333
SET(BUILD_CMD make HAS_SYSTEM_PROTOBUF=false -s -j ${NUM_OF_PROCESSOR} static grpc_cpp_plugin)
3434
ENDIF()
3535

36+
# FIXME(wuyi): do not build zlib cares protobuf twice, find a way to build grpc with them
3637
ExternalProject_Add(
3738
extern_grpc
3839
DEPENDS protobuf zlib
39-
URL "http://paddlepaddledeps.bj.bcebos.com/grpc.tar.xz"
40+
# NOTE(wuyi):
41+
# this package is generated by following steps:
42+
# 1. git clone -b v1.8.x https://github.com/grpc/grpc.git
43+
# 2. submodule update --init
44+
# 3. keep only zlib, cares, protobuf, boringssl under "third_party",
45+
# checkout and clean other dirs under third_party
46+
# 4. remove .git, and package the directory.
47+
URL "http://paddlepaddledeps.bj.bcebos.com/grpc-v1.8.x.tar.gz"
4048
PREFIX ${GRPC_SOURCES_DIR}
4149
UPDATE_COMMAND ""
4250
CONFIGURE_COMMAND ""
@@ -49,7 +57,6 @@ ExternalProject_Add(
4957
INSTALL_COMMAND make prefix=${GRPC_INSTALL_DIR} install
5058
)
5159

52-
# FIXME(typhoonzero): hack to get static lib path, try a better way like merge them.
5360
ADD_LIBRARY(grpc++_unsecure STATIC IMPORTED GLOBAL)
5461
SET_PROPERTY(TARGET grpc++_unsecure PROPERTY IMPORTED_LOCATION
5562
"${GRPC_INSTALL_DIR}/lib/libgrpc++_unsecure.a")

0 commit comments

Comments
 (0)