Skip to content

Commit 9c2d7df

Browse files
committed
optimize code
1 parent 570be39 commit 9c2d7df

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

paddle/fluid/operators/listen_and_serv_op.cc

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,13 @@ static void ParallelExecuteBlocks(
4848
for (size_t i = 0; i < fs.size(); ++i) fs[i].wait();
4949
}
5050

51+
static void SavePort(std::shared_ptr<detail::AsyncGRPCServer> rpc_service) {
52+
std::ofstream port_file;
53+
port_file.open("/tmp/paddle.selected_port");
54+
port_file << rpc_service->GetSelectedPort();
55+
port_file.close();
56+
}
57+
5158
ListenAndServOp::ListenAndServOp(const std::string &type,
5259
const framework::VariableNameMap &inputs,
5360
const framework::VariableNameMap &outputs,
@@ -66,9 +73,8 @@ void ListenAndServOp::Stop() {
6673
void ListenAndServOp::PreparePrefetchCtx(
6774
framework::Executor *executor, framework::BlockDesc *prefetch_block,
6875
framework::ProgramDesc *program) const {
69-
// TODO(qiao) set proper fields for table lookup and update
70-
rpc_service_->SetExecutor(executor);
7176
VLOG(3) << "prefetch block id is " << prefetch_block->ID();
77+
rpc_service_->SetExecutor(executor);
7278
auto prefetch_prepared = executor->Prepare(*program, prefetch_block->ID());
7379
rpc_service_->SetPrefetchBlkdId(prefetch_block->ID());
7480
rpc_service_->SetPrefetchPreparedCtx(prefetch_prepared.get());
@@ -134,7 +140,7 @@ void ListenAndServOp::RunSyncUpdate(
134140
break;
135141
}
136142

137-
// NOTE: if is_gpu_place, CUDA kernels are launch by multiple threads
143+
// NOTE: if is_gpu_place, CUDA kernels are launched by multiple threads
138144
// and this will still work.
139145

140146
// The optimize blocks which have the same parent ID would run parallel
@@ -173,13 +179,6 @@ void ListenAndServOp::RunSyncUpdate(
173179
} // while(true)
174180
}
175181

176-
static void SavePort(std::shared_ptr<detail::AsyncGRPCServer> rpc_service) {
177-
std::ofstream port_file;
178-
port_file.open("/tmp/paddle.selected_port");
179-
port_file << rpc_service->GetSelectedPort();
180-
port_file.close();
181-
}
182-
183182
void ListenAndServOp::RunImpl(const framework::Scope &scope,
184183
const platform::Place &dev_place) const {
185184
platform::DeviceContextPool &pool = platform::DeviceContextPool::Instance();

0 commit comments

Comments
 (0)