Skip to content

Commit a229734

Browse files
reyoungreyoung
committed
Remove cpplint in cmake
1 parent b1d4468 commit a229734

File tree

18 files changed

+3
-122
lines changed

18 files changed

+3
-122
lines changed

‎CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ option(WITH_MKL "Compile PaddlePaddle with MKL support." ${AVX_FO
4141
option(WITH_DSO "Compile PaddlePaddle with dynamic linked CUDA" ON)
4242
option(WITH_TESTING "Compile PaddlePaddle with unit testing" OFF)
4343
option(WITH_SWIG_PY "Compile PaddlePaddle with inference api" ON)
44-
option(WITH_STYLE_CHECK "Compile PaddlePaddle with style check" ON)
4544
option(WITH_PYTHON "Compile PaddlePaddle with python interpreter" ON)
4645
option(WITH_DOUBLE "Compile PaddlePaddle with double precision" OFF)
4746
option(WITH_RDMA "Compile PaddlePaddle with RDMA support" OFF)
@@ -155,7 +154,6 @@ include(cupti)
155154
include(configure) # add paddle env configuration
156155
include(generic) # simplify cmake module
157156
include(package) # set paddle packages
158-
include(cpplint) # set paddle c++ style
159157
include(ccache) # set ccache for compilation
160158
include(util) # set unittest and link libs
161159
include(rdma) # set rdma libraries

‎cmake/cpplint.cmake

Lines changed: 0 additions & 62 deletions
This file was deleted.

‎cmake/generic.cmake

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,6 @@ function(cc_library TARGET_NAME)
206206
list(APPEND cc_library_HEADERS ${CMAKE_CURRENT_SOURCE_DIR}/${source}.h)
207207
endif()
208208
endforeach()
209-
add_style_check_target(${TARGET_NAME} ${cc_library_SRCS} ${cc_library_HEADERS})
210-
211209
else(cc_library_SRCS)
212210
if(cc_library_DEPS)
213211
merge_static_libs(${TARGET_NAME} ${cc_library_DEPS})
@@ -271,7 +269,6 @@ function(nv_library TARGET_NAME)
271269
list(APPEND nv_library_HEADERS ${CMAKE_CURRENT_SOURCE_DIR}/${source}.h)
272270
endif()
273271
endforeach()
274-
add_style_check_target(${TARGET_NAME} ${nv_library_SRCS} ${nv_library_HEADERS})
275272
else(nv_library_SRCS)
276273
if (nv_library_DEPS)
277274
merge_static_libs(${TARGET_NAME} ${nv_library_DEPS})
@@ -344,7 +341,6 @@ function(hip_library TARGET_NAME)
344341
list(APPEND hip_library_HEADERS ${CMAKE_CURRENT_SOURCE_DIR}/${source}.h)
345342
endif()
346343
endforeach()
347-
add_style_check_target(${TARGET_NAME} ${hip_library_SRCS} ${hip_library_HEADERS})
348344
else(hip_library_SRCS)
349345
if (hip_library_DEPS)
350346
merge_static_libs(${TARGET_NAME} ${hip_library_DEPS})

‎go/pserver/client/c/test/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,3 @@
1313
# limitations under the License.
1414
#
1515
cc_test(test_cclient SRCS test_cclient.c DEPS paddle_pserver_cclient paddle_go_optimizer)
16-
add_style_check_target(test_cclient test_cclient.c)

‎paddle/capi/CMakeLists.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@ add_library(paddle_capi STATIC ${CAPI_HEADERS} ${CAPI_PRIVATE_HEADER}
3333

3434
target_include_directories(paddle_capi PUBLIC ${CMAKE_CURRENT_BINARY_DIR})
3535

36-
add_style_check_target(paddle_capi ${CAPI_SOURCES} ${CAPI_HEADER}
37-
${CAPI_PRIVATE_HEADER})
38-
3936
add_dependencies(paddle_capi paddle_proto paddle_gserver)
4037

4138
# TODO: paddle_capi_whole will be removed.

‎paddle/cuda/CMakeLists.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,3 @@ else()
8787
endif()
8888

8989
add_dependencies(paddle_cuda paddle_proto ${external_project_dependencies})
90-
91-
add_style_check_target(paddle_cuda
92-
${CUDA_SOURCES}
93-
${CUDA_HEADERS}
94-
${CUDA_CXX_SOURCES})

‎paddle/function/CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,3 @@ add_simple_unittest(Im2ColTest)
5252
add_simple_unittest(GemmConvOpTest)
5353
add_simple_unittest(DepthwiseConvOpTest)
5454
endif()
55-
56-
add_style_check_target(paddle_function ${h_files})
57-
add_style_check_target(paddle_function ${cpp_files})
58-
if(WITH_GPU)
59-
add_style_check_target(paddle_function ${cu_files})
60-
endif()

‎paddle/gserver/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,6 @@ else()
146146
${GSERVER_SOURCES})
147147
endif()
148148

149-
add_style_check_target(paddle_gserver ${GSERVER_SOURCES})
150-
add_style_check_target(paddle_gserver ${GSERVER_HEADER})
151149
add_dependencies(paddle_gserver paddle_proto ${external_project_dependencies})
152150
if(WITH_TESTING)
153151
add_subdirectory(tests)

‎paddle/math/CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ else()
5151
endif()
5252

5353

54-
55-
add_style_check_target(paddle_math ${MATH_SOURCES})
56-
add_style_check_target(paddle_math ${MATH_HEADERS})
57-
5854
add_dependencies(paddle_math paddle_proto ${external_project_dependencies}) # depends
5955
if(WITH_TESTING)
6056
add_subdirectory(tests)

‎paddle/parameter/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ file(GLOB PARAMETERS_SOURCES . *.cpp)
55

66
add_library(paddle_parameter STATIC
77
${PARAMETERS_SOURCES})
8-
add_style_check_target(paddle_parameter ${PARAMETERS_SOURCES})
9-
add_style_check_target(paddle_parameter ${PARAMETERS_HEADERS})
108
add_dependencies(paddle_parameter paddle_proto ${external_project_dependencies})
119
if(WITH_TESTING)
1210
add_subdirectory(tests)

0 commit comments

Comments
 (0)