Skip to content

Commit a569615

Browse files
tianshuo78520aluotao1
authored andcommitted
1.5 api approve (#19416)
* change api approve * update * test=develop * test=develop
1 parent cb74dac commit a569615

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

paddle/scripts/paddle_build.sh

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -509,32 +509,31 @@ function assert_api_spec_approvals() {
509509
echo "checking ${API_FILE} change, PR: ${GIT_PR_ID}, changes: ${API_CHANGE}"
510510
if [ "${API_CHANGE}" ] && [ "${GIT_PR_ID}" != "" ]; then
511511
# NOTE: per_page=10000 should be ok for all cases, a PR review > 10000 is not human readable.
512-
# approval_user_list: XiaoguangHu01 46782768,chengduoZH 30176695,Xreki 12538138,luotao1 6836917,sneaxiy 32832641,tensor-tang 21351065,jacquesqiao 3048612,xsrobin 50069408,qingqing01 7845005,junjun315 3124479,shanyi15 35982308.
512+
# approval_user_list: XiaoguangHu01 46782768,chengduoZH 30176695,Xreki 12538138,luotao1 6836917,sneaxiy 32832641,tensor-tang 21351065,xsrobin 50069408,qingqing01 7845005,guoshengCS 14105589,heavengate 12605721,kuke 3064195,Superjomn 328693,lanxianghit 47554610,cyj1986 39645414,hutuxian 11195205,frankwhzhang 20274488,nepeplwu 45024560,Dianhai 5086632,JiabinYang 22361972,chenwhql 22561442.
513513
approval_line=`curl -H "Authorization: token ${GITHUB_API_TOKEN}" https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID}/reviews?per_page=10000`
514514
if [ "${API_FILE}" == "paddle/fluid/API.spec" ];then
515-
APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 46782768 30176695 6836917 7845005`
516-
if [ "${APPROVALS}" == "TRUE" ];then
517-
APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 50069408 35982308`
518-
fi
515+
APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 2 7534971 14105589 12605721 3064195 328693 47554610 39645414 11195205 20274488 45024560 `
519516
elif [ "${API_FILE}" == "CMakeLists.txt" ];then
520517
APPROVALS=`curl -H "Authorization: token ${GITHUB_API_TOKEN}" https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID}/reviews?per_page=10000 | \
521518
python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 6836917 46782768 30176695`
522519
elif [ "${API_FILE}" == "python/paddle/fluid/__init__.py" ];then
523-
APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 50069408 35982308`
520+
APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 6836917 47554610`
524521
elif [ "${API_FILE}" == "python/requirements.txt" ];then
525-
APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 3124479 6836917`
522+
APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 6836917 22361972`
526523
else
527524
APPROVALS=`curl -H "Authorization: token ${GITHUB_API_TOKEN}" https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID}/reviews?per_page=10000 | \
528525
python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 21351065 3048612 46782768 30176695 12538138 6836917 32832641`
529526
fi
530527
echo "current pr ${GIT_PR_ID} got approvals: ${APPROVALS}"
531528
if [ "${APPROVALS}" == "FALSE" ]; then
532529
if [ "${API_FILE}" == "paddle/fluid/API.spec" ];then
533-
echo "You must have one RD (chengduoZH or XiaoguangHu01 or qingqing01 or luotao1) and one PM (xsrobin) approval for the api change! ${API_FILE} for the management reason of API interface and API document."
530+
echo "You must have two RD (wanghaoshuang or guoshengCS or heavengate or kuke or Superjomn or lanxianghit or cyj1986 or hutuxian or frankwhzhang or nepeplwu) approval for the api change! ${API_FILE} for the management reason of API interface and API document."
534531
elif [ "${API_FILE}" == "CMakeLists.txt" ];then
535532
echo "You must have one RD (luotao1 or chengduoZH or XiaoguangHu01) approval for the cmakelist change! ${API_FILE} for the management reason of the Compilation parameter."
536533
elif [ "${API_FILE}" == "python/paddle/fluid/__init__.py" ];then
537-
echo "You must have xsrobin approval for the python/paddle/fluid/__init__.py change! ${API_FILE} for the management reason of the environment variables."
534+
echo "You must have one RD (lanxianghit (Recommend) or luotao1) approval for the python/paddle/fluid/init.py, which manages the environment variables."
535+
elif [ "${API_FILE}" == "python/requirements.txt" ];then
536+
echo "You must have one RD (JiabinYang (Recommend) or luotao1) approval for python/requirements.txt, which manages the third-party python package."
538537
else
539538
echo "You must have one RD (XiaoguangHu01,chengduoZH,Xreki,luotao1,sneaxiy,tensor-tang,jacquesqiao) approval for the api change! ${API_FILE} for the management reason of the underlying code for fluid."
540539
fi

0 commit comments

Comments
 (0)