Skip to content

Commit aa84b21

Browse files
committed
fix unit tests
1 parent d723022 commit aa84b21

File tree

3 files changed

+16
-14
lines changed

3 files changed

+16
-14
lines changed

paddle/fluid/operators/listen_and_serv_op.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ void ListenAndServOp::RunImpl(const framework::Scope &scope,
262262

263263
auto optimize_blocks =
264264
Attr<std::vector<framework::BlockDesc *>>(kOptimizeBlocks);
265-
PADDLE_ENFORCE(optimize_blocks.size() > 1,
265+
PADDLE_ENFORCE(optimize_blocks.size() >= 1,
266266
"optimize blocks should be 1 at least on the pserver side.");
267267
auto *program = optimize_blocks[0]->Program();
268268
framework::Executor executor(dev_place);

python/paddle/fluid/framework.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -558,19 +558,20 @@ def find_name(var_list, name):
558558
if (attr_name not in self.attrs) or (
559559
self.attrs[attr_name] is None):
560560
continue
561-
if isinstance(self.attrs[attr_name], Block):
561+
attr_val = self.attrs[attr_name]
562+
if isinstance(attr_val, Block):
562563
self.desc.set_block_attr(attr_name,
563564
self.attrs[attr_name].desc)
564-
elif isinstance(self.attrs[attr_name], list) and \
565-
all(isinstance(v, Block) for v in self.attrs[attr_name]):
566-
self.desc.set_blocks_attr(
567-
attr_name, [v.desc for v in self.attrs[attr_name]])
568-
elif isinstance(self.attrs[attr_name], core.BlockDesc) or \
569-
isinstance(self.attrs[attr_name], core.ProgramDesc):
565+
elif isinstance(attr_val, list) and attr_val and \
566+
all(isinstance(v, Block) for v in attr_val):
567+
self.desc.set_blocks_attr(attr_name,
568+
[v.desc for v in attr_val])
569+
elif isinstance(attr_val, core.BlockDesc) or \
570+
isinstance(attr_val, core.ProgramDesc):
570571
self.desc.set_serialized_attr(
571-
attr_name, self.attrs[attr_name].serialize_to_string())
572+
attr_name, attr_val.serialize_to_string())
572573
else:
573-
self.desc.set_attr(attr_name, self.attrs[attr_name])
574+
self.desc.set_attr(attr_name, attr_val)
574575
self.desc.check_attrs()
575576
if self.has_kernel(type):
576577
self.desc.infer_var_type(self.block.desc)
@@ -719,7 +720,8 @@ def set_attr(self, name, val):
719720
self.attrs[name] = val
720721
if isinstance(val, Block):
721722
self.desc.set_block_attr(name, val.desc)
722-
elif isinstance(val, list) and all(isinstance(v, Block) for v in val):
723+
elif isinstance(val, list) and val and all(
724+
isinstance(v, Block) for v in val):
723725
self.desc.set_blocks_attr(name, [v.desc for v in val])
724726
elif isinstance(val, core.BlockDesc) or \
725727
isinstance(val, core.ProgramDesc):

python/paddle/fluid/layers/io.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,6 @@ def complete_op(self):
186186
main_program = self.helper.main_program
187187
current_block = main_program.current_block()
188188
parent_block = self.parent_block()
189-
empty_block = Program().global_block()
190189

191190
parent_block.append_op(
192191
type='listen_and_serv',
@@ -195,8 +194,9 @@ def complete_op(self):
195194
attrs={
196195
'endpoint': self.endpoint,
197196
'Fanin': self.fan_in,
198-
'OptimizeBlock': current_block,
199-
'PrefetchBlock': empty_block,
197+
'optimize_blocks': [
198+
current_block
199+
], # did not support multiple optimize blocks in layers
200200
'sync_mode': True, # did not support async now in layers
201201
'grad_to_block_id': [""]
202202
})

0 commit comments

Comments
 (0)