Skip to content

Commit d8ddd3b

Browse files
committed
Add TODO for memory optimization in python3 and polishing code
1 parent 7f794ea commit d8ddd3b

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

python/paddle/fluid/io.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -606,6 +606,7 @@ def save_inference_model(dirname,
606606
feeded_var_names = [feeded_var_names.encode()]
607607
else:
608608
if len(feeded_var_names) > 0:
609+
# TODO(paddle-dev): polish these code blocks
609610
if not (bool(feeded_var_names) and all(
610611
isinstance(name, six.binary_type)
611612
for name in feeded_var_names)):

python/paddle/fluid/transpiler/distribute_transpiler.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1245,6 +1245,8 @@ def _append_pserver_ops(self, optimize_block, opt_op, endpoint,
12451245

12461246
def _is_splited_grad_var(self, var, var_dict):
12471247
grad_block = None
1248+
# TODO(minqiyang): replace these items() with six.iteritems() to
1249+
# improve memory
12481250
for _, g in list(var_dict.items()):
12491251
if self._orig_varname(g.name) == self._orig_varname(var.name):
12501252
if g.name.find(".trainer_") == -1:

0 commit comments

Comments
 (0)