add FlagCX as optional communication library when using iluvatar gpus #1862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikethegoblin
commented
Aug 1, 2025
mikethegoblin
commented
- modified runtime.cc to include flagcx implementation
- modified compilation scripts to optionally compile with FlagCX
|
Thanks for your contribution! |
yongqiangma
reviewed
Aug 29, 2025
| @@ -811,17 +892,32 @@ C_Status XcclCommInitRank(size_t nranks, | |||
| C_CCLRootId *unique_id, | |||
| size_t rank, | |||
| C_CCLComm *comm) { | |||
| #if defined(PADDLE_WITH_FLAGCX) | |||
There was a problem hiding this comment.
这个文件里的修改大部分都一样，是不是通过一个map或者脚本，将对应的变量或函数进行替换，只有差异化的地方用宏来控制。
这样如果其他后端修改，这个脚本的方法大部分也可以复用
There was a problem hiding this comment.
已将flagcx相关实现放到单独的文件runtime_flagcx.cc，这个文件的实现如果日后需要适配其他后端可直接复用
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.