Skip to content

Conversation

algorithm1832
Copy link

PR Category

Custom Device

PR Types

Improvements

Description

  • Replace .cu includes to .h includes
  • Add .cu file to cmakelists

Related Paddle PR: #75592
After merging the above PR this PR will be marked as ready


#include "paddle/phi/core/kernel_registry.h"
#include "paddle/phi/kernels/gpu/box_clip_kernel.cu" //NOLINT
#include "paddle/phi/kernels/gpu/box_clip_kernel.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iluvatar的编译列表中需要添加box_clip_kernel.cu

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iluvatar的CMakeLists中第300行已经包括box_clip_kernel.cu

${PADDLE_SOURCE_DIR}/paddle/phi/kernels/gpu/box_clip_kernel.cu

它和其它文件已写入CUDA_SRCS2,并包含在CUDA_SRCS中去重
对应位置的操作为

set(CUDA_SRCS ${CUDA_SRCS1} ${CUDA_SRCS2})
list(REMOVE_DUPLICATES CUDA_SRCS1)

那么我还需要在CMakeLists中的其它位置添加box_clip_kernel.cu吗?

@YqGe585 YqGe585 added contributor HappyOpenSource 快乐开源活动issue与PR labels Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants