Skip to content

Commit 196fff8

Browse files
authored
fix: csi mount default 0777 0777 (#1092)
* fix: csi mount default 0777 0777 * fix: csi mount default 0777 0777
1 parent c712ef0 commit 196fff8

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

pkg/fs/csiplugin/mount/info.go

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import (
2525
corev1 "k8s.io/api/core/v1"
2626

2727
"github.com/PaddlePaddle/PaddleFlow/pkg/common/schema"
28-
"github.com/PaddlePaddle/PaddleFlow/pkg/fs/client/ufs"
2928
"github.com/PaddlePaddle/PaddleFlow/pkg/fs/common"
3029
"github.com/PaddlePaddle/PaddleFlow/pkg/fs/csiplugin/csiconfig"
3130
"github.com/PaddlePaddle/PaddleFlow/pkg/fs/utils"
@@ -210,18 +209,15 @@ func (mountInfo *Info) commonOptions() []string {
210209
options = append(options, "--log-level=debug")
211210
}
212211

213-
// s3 default mount permission
214-
if mountInfo.FS.Type == common.S3Type {
215-
if mountInfo.FS.PropertiesMap[common.FileMode] != "" {
216-
options = append(options, fmt.Sprintf("--%s=%s", "file-mode", mountInfo.FS.PropertiesMap[common.FileMode]))
217-
} else {
218-
options = append(options, fmt.Sprintf("--%s=%v", "file-mode", ufs.DefaultFileMode))
219-
}
220-
if mountInfo.FS.PropertiesMap[common.DirMode] != "" {
221-
options = append(options, fmt.Sprintf("--%s=%s", "dir-mode", mountInfo.FS.PropertiesMap[common.DirMode]))
222-
} else {
223-
options = append(options, fmt.Sprintf("--%s=%v", "dir-mode", ufs.DefaultDirMode))
224-
}
212+
if mountInfo.FS.PropertiesMap[common.FileMode] != "" {
213+
options = append(options, fmt.Sprintf("--%s=%s", "file-mode", mountInfo.FS.PropertiesMap[common.FileMode]))
214+
} else {
215+
options = append(options, fmt.Sprintf("--%s=%v", "file-mode", "0777"))
216+
}
217+
if mountInfo.FS.PropertiesMap[common.DirMode] != "" {
218+
options = append(options, fmt.Sprintf("--%s=%s", "dir-mode", mountInfo.FS.PropertiesMap[common.DirMode]))
219+
} else {
220+
options = append(options, fmt.Sprintf("--%s=%v", "dir-mode", "0777"))
225221
}
226222
return options
227223
}

pkg/fs/csiplugin/mount/info_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ func TestInfo_MountCmdArgs(t *testing.T) {
232232
CacheConfig: fsCache,
233233
TargetPath: targetPath,
234234
},
235-
want: "/home/paddleflow/pfs-fuse mount --mount-point=/home/paddleflow/mnt/storage --fs-id=fs-root-bos --sts=true --server=paddleflow-server:8999 --block-size=4096 --meta-cache-driver=disk --data-cache-path=/home/paddleflow/pfs-cache/data-cache --meta-cache-path=/home/paddleflow/pfs-cache/meta-cache",
235+
want: "/home/paddleflow/pfs-fuse mount --mount-point=/home/paddleflow/mnt/storage --fs-id=fs-root-bos --sts=true --server=paddleflow-server:8999 --block-size=4096 --meta-cache-driver=disk --file-mode=0777 --dir-mode=0777 --data-cache-path=/home/paddleflow/pfs-cache/data-cache --meta-cache-path=/home/paddleflow/pfs-cache/meta-cache",
236236
},
237237
{
238238
name: "test-bos-err",

0 commit comments

Comments
 (0)