Skip to content

Conversation

@mengziheng
Copy link
Contributor

PR types

Performance optimization

PR changes

Models

Description

merge silu op as producer
here is difference:
image
image

@paddle-bot
Copy link

paddle-bot bot commented Feb 9, 2023

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

text_encoder_runtime = create_ort_runtime(
args.model_dir, args.text_encoder_model_prefix, args.model_format, device_id=device_id
text_encoder_runtime = create_paddle_inference_runtime(
args.model_dir,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件暂时先不要修改

resnet_act_fn=resnet_act_fn,
resnet_groups=resnet_groups,
resnet_time_scale_shift=resnet_time_scale_shift,
resnet_pre_temb_non_linearity=False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是固定为False吗


# 3. down
down_block_res_samples = (sample,)
down_nonlinear_temb = self.down_resnet_temb_nonlinearity(emb)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这应该给个判断吧,只有resnet_pre_temb_non_linearity=True的时候才做这个


# 3. down
down_block_res_samples = (sample,)
down_nonlinear_temb = self.down_resnet_temb_nonlinearity(emb)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑这里是否需要对resnet_pre_temb_non_linearity先进行判断后再对down_nonlinear_temb进行赋值
like
if resnet_pre_temb_non_linearity:
down_nonlinear_temb = self.down_resnet_temb_nonlinearity(emb)
else:
down_nonlinear_temb = emb

@github-actions
Copy link

This Pull Request is stale because it has been open for 60 days with no activity. 当前Pull Request 60天内无活动,被标记为stale。

@github-actions
Copy link

This Pull Request is stale because it has been open for 60 days with no activity. 当前Pull Request 60天内无活动,被标记为stale。

@github-actions
Copy link

This Pull Request is stale because it has been open for 60 days with no activity. 当前Pull Request 60天内无活动,被标记为stale。

@github-actions github-actions bot added the stale label May 10, 2024
@github-actions github-actions bot removed the stale label Oct 16, 2024
@github-actions
Copy link

This Pull Request is stale because it has been open for 60 days with no activity. 当前Pull Request 60天内无活动,被标记为stale。

@github-actions github-actions bot added the stale label Dec 16, 2024
@paddle-bot paddle-bot bot closed this Dec 23, 2025
@paddle-bot
Copy link

paddle-bot bot commented Dec 23, 2025

Automatically closed by Paddle-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants