Skip to content

Commit 7192e30

Browse files
authored
Modify konnectors' job and chart name to better align with conventions (#31)
* Modify konnectors' job and chart name to better align with conventions * Return the name of the helm chart to konnector * Changing konnector job name to cortex-syncer
1 parent fbf21a2 commit 7192e30

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

charts/konnector/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: konnector
33
description: Deploys Palo Alto Networks' Cortex KSPM connector for advanced Kubernetes security posture management.
44
type: application
5-
version: 1.0.24-rc.6
5+
version: 1.0.24-rc.7
66
appVersion: "1.0.0"
77
maintainers:
88
- name: Palo Alto Networks - Cortex KSPM team

charts/konnector/templates/_helpers.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,11 @@ spec:
7070
secretName: {{ .Values.system.secrets.backendAuth.name }}
7171
serviceAccountName: {{ .Values.system.serviceAccount.name }}
7272
containers:
73-
- name: {{ .Chart.Name }}
73+
- name: {{ .Values.system.batch.name }}
7474
image: "{{ .Values.image.repository }}/{{ .Values.image.name }}{{- if .Values.image.tag }}:{{ .Values.image.tag }}{{- end }}{{- if .Values.image.digest }}@{{ .Values.image.digest }}{{- end }}"
7575
resources:
7676
{{- toYaml .Values.system.apps.resources | nindent 12 }}
77-
command: [/{{ .Chart.Name }}]
77+
command: [/konnector]
7878
env:
7979
- name: NAMESPACE
8080
valueFrom:

charts/konnector/templates/batch.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
apiVersion: batch/v1
44
kind: Job
55
metadata:
6-
name: "{{ .Chart.Name }}-job-revision-{{ .Release.Revision }}"
6+
name: "{{ .Values.system.batch.name }}-job-revision-{{ .Release.Revision }}"
77
namespace: {{ .Values.namespace.name }}
88
labels:
99
{{- include "common.labels" . | nindent 4 }}
@@ -13,7 +13,7 @@ metadata:
1313
apiVersion: batch/v1
1414
kind: CronJob
1515
metadata:
16-
name: {{ .Chart.Name }}
16+
name: {{ .Values.system.batch.name }}
1717
namespace: {{ .Values.namespace.name }}
1818
labels:
1919
{{- include "common.labels" . | nindent 4 }}
@@ -26,7 +26,7 @@ spec:
2626
apiVersion: batch/v1
2727
kind: Job
2828
metadata:
29-
name: delete-{{ .Values.system.K8sManager.ReleaseName }}
29+
name: delete-{{ .Values.system.batch.name }}
3030
namespace: {{ .Values.namespace.name }}
3131
annotations:
3232
"helm.sh/hook": pre-delete

charts/konnector/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ system:
6363
batch:
6464
backoffLimit: 4 # Maximum number of retries before the job is considered failed. After 4 attempts, the job will fail.
6565
ttlSecondsAfterFinished: 3600 # Time-to-live for completed jobs, jobs will be automatically deleted 3600 seconds (1 hour) after completion
66+
name: "cortex-syncer"
6667
cleanupJob:
6768
resources:
6869
requests:

0 commit comments

Comments
 (0)