re-doing commit

Author: shinmog

.idea/.gitignore

@@ -197,58 +197,20 @@ func Test_config_setup_FoldersAPIService_Update(t *testing.T) {
 
 // ---
 
-// Test_config_setup_FoldersAPIService_List tests listing folders
+// Test_config_setup_FoldersAPIService_List tests listing folders (read-only)
 func Test_config_setup_FoldersAPIService_List(t *testing.T) {
-	t.Skip("API returns 500 Internal Server Error on folder create - folder creation not supported in test environment")
 	// Setup the authenticated client
 	client := SetupConfigSvcTestClient(t)
 
-	// 1. Create a folder first to have something to list
-	createdFolderName := "test-folder-list-" + common.GenerateRandomString(10)
-	folder := config_setup.Folders{
-		Description: common.StringPtr("Test folder for list API testing"),
-		Name:        createdFolderName,
-		Parent:      "Shared",
-	}
-
-	// Create the folder via API
-	reqCreate := client.FoldersAPI.CreateFolder(context.Background()).Folders(folder)
-	createRes, _, err := reqCreate.Execute()
-	if err != nil {
-		handleAPIError(err)
-	}
-	require.NoError(t, err, "Failed to create folder for list test")
-	createdFolderID := createRes.Id
-	require.NotEmpty(t, createdFolderID, "Created folder should have an ID")
-
-	// 2. Test List operation
-	reqList := client.FoldersAPI.ListFolders(context.Background()).Limit(500)
-	listRes, httpResList, errList := reqList.Execute()
+	// Read-only test: list existing folders (Create gives 500, but List works independently)
+	listRes, httpResList, errList := client.FoldersAPI.ListFolders(context.Background()).Limit(200).Offset(0).Execute()
 	if errList != nil {
 		handleAPIError(errList)
 	}
-
-	// Verify the list operation was successful
 	require.NoError(t, errList, "Failed to list folders")
 	assert.Equal(t, 200, httpResList.StatusCode, "Expected 200 OK status")
-
-	// Assert response object properties
 	require.NotNil(t, listRes, "List response should not be nil")
-	require.NotNil(t, listRes.Data, "List response data should not be nil")
-	assert.GreaterOrEqual(t, len(listRes.Data), 1, "Expected at least 1 folder in the list response")
-
-	t.Logf("Successfully listed and found created folder: %s", createdFolderName)
-
-	// 3. Cleanup: Delete the created folder
-	reqDel := client.FoldersAPI.DeleteFolderByID(context.Background(), createdFolderID)
-	httpResDel, errDel := reqDel.Execute()
-	if errDel != nil {
-		handleAPIError(errDel)
-	}
-	require.NoError(t, errDel, "Failed to delete folder during cleanup")
-	assert.Equal(t, 200, httpResDel.StatusCode, "Expected 200 OK status for delete")
-
-	t.Logf("Successfully cleaned up folder: %s", createdFolderID)
+	t.Logf("Successfully listed folders, total: %d", listRes.GetTotal())
 }
 
 // ---
@@ -299,60 +261,19 @@ func Test_config_setup_FoldersAPIService_DeleteByID(t *testing.T) {
 	assert.Equal(t, 404, httpResGet.StatusCode, "Expected 404 Not Found status after deletion")
 }
 
-// Test_config_setup_FoldersAPIService_FetchFolders tests the FetchFolders convenience method
+// Test_config_setup_FoldersAPIService_FetchFolders tests the FetchFolders convenience method (read-only)
 func Test_config_setup_FoldersAPIService_FetchFolders(t *testing.T) {
-	t.Skip("API returns 500 Internal Server Error on folder create - folder creation not supported in test environment")
 	// Setup the authenticated client
 	client := SetupConfigSvcTestClient(t)
 
-	// Create test object using same payload as Create test
-	testName := "test-folder-fetch-" + common.GenerateRandomString(6)
-	testObj := config_setup.Folders{
-		Description: common.StringPtr("Test folder for fetch API testing"),
-		Name:        testName,
-		Parent:      "Shared",
-	}
-
-	createReq := client.FoldersAPI.CreateFolder(context.Background()).Folders(testObj)
-	createRes, _, err := createReq.Execute()
-	if err != nil {
-		handleAPIError(err)
-	}
-	require.NoError(t, err, "Failed to create test object for fetch test")
-	require.NotNil(t, createRes, "Create response should not be nil")
-	createdID := createRes.Id
-
-	// Cleanup after test
-	defer func() {
-		deleteReq := client.FoldersAPI.DeleteFolderByID(context.Background(), createdID)
-		_, _ = deleteReq.Execute()
-		t.Logf("Cleaned up test object: %s", createdID)
-	}()
-
-	// Test 1: Fetch existing object by name
-	fetchedObj, err := client.FoldersAPI.FetchFolders(
+	// Read-only test: Fetch non-existent object (should return nil, nil)
+	notFound, err := client.FoldersAPI.FetchFolders(
 		context.Background(),
-		testName,
-		nil, // folder (folders don't have folder field)
+		"non-existent-folder-xyz-12345",
+		nil, // folder
 		nil, // snippet
 		nil, // device
 	)
-
-	// Verify successful fetch
-	require.NoError(t, err, "Failed to fetch folders by name")
-	require.NotNil(t, fetchedObj, "Fetched object should not be nil")
-	assert.Equal(t, createdID, fetchedObj.Id, "Fetched object ID should match")
-	assert.Equal(t, testName, fetchedObj.Name, "Fetched object name should match")
-	t.Logf("[SUCCESS] FetchFolders found object: %s", fetchedObj.Name)
-
-	// Test 2: Fetch non-existent object (should return nil, nil)
-	notFound, err := client.FoldersAPI.FetchFolders(
-		context.Background(),
-		"non-existent-folders-xyz-12345",
-		nil, // folder (folders don't have folder field)
-		nil,
-		nil,
-	)
 	require.NoError(t, err, "Fetch should not error for non-existent object")
 	assert.Nil(t, notFound, "Should return nil for non-existent object")
 	t.Logf("[SUCCESS] FetchFolders correctly returned nil for non-existent object")

.idea/go.imports.xml

@@ -128,42 +128,18 @@ func Test_deployment_services_SitesAPIService_Update(t *testing.T) {
 	assert.Equal(t, "123 Updated Street", *updateRes.AddressLine1, "Address should be updated")
 }
 
-// Test_deployment_services_SitesAPIService_List tests listing Sites.
+// Test_deployment_services_SitesAPIService_List tests listing Sites (read-only).
 func Test_deployment_services_SitesAPIService_List(t *testing.T) {
-	t.Skip("Skipping test: Sites model has non-pointer Id field (Id string), which causes issues with object creation as the API populates this field")
-
-	depSvcClient := SetupDeploymentSvcTestClient(t)
-	randomSuffix := common.GenerateRandomString(6)
+	client := SetupDeploymentSvcTestClient(t)
 
-	// Create a site to ensure it appears in the list.
-	siteName := "test-site-list-" + randomSuffix
-	site := deployment_services.Sites{
-		Name: siteName,
-		Id:   "", // Will be populated by API
+	listRes, httpResList, errList := client.SitesAPI.ListSites(context.Background()).Folder("All").Limit(200).Offset(0).Execute()
+	if errList != nil {
+		handleAPIError(errList)
 	}
-	createRes, _, err := depSvcClient.SitesAPI.CreateSites(context.Background()).Sites(site).Execute()
-	require.NoError(t, err, "Failed to create site for list test")
-	createdSiteID := createRes.Id
-	defer func() {
-		depSvcClient.SitesAPI.DeleteSitesByID(context.Background(), createdSiteID).Execute()
-	}()
-
-	// Test List operation.
-	// Note: Sites API requires folder parameter
-	listRes, httpResList, errList := depSvcClient.SitesAPI.ListSites(context.Background()).Folder("All").Limit(10000).Execute()
 	require.NoError(t, errList, "Failed to list sites")
-	assert.Equal(t, 200, httpResList.StatusCode)
-	require.NotNil(t, listRes)
-
-	// Verify our created site is in the list.
-	foundSite := false
-	for _, s := range listRes.Data {
-		if s.Name == siteName {
-			foundSite = true
-			break
-		}
-	}
-	assert.True(t, foundSite, "Created site should be found in the list")
+	assert.Equal(t, 200, httpResList.StatusCode, "Expected 200 OK status")
+	require.NotNil(t, listRes, "List response should not be nil")
+	t.Logf("Successfully listed sites, total: %d", listRes.GetTotal())
 }
 
 // Test_deployment_services_SitesAPIService_DeleteByID tests deleting a site by ID.
@@ -188,58 +164,13 @@ func Test_deployment_services_SitesAPIService_DeleteByID(t *testing.T) {
 	require.NoError(t, errDel, "Failed to delete site")
 }
 
-// Test_deployment_services_SitesAPIService_FetchSites tests the FetchSites convenience method
+// Test_deployment_services_SitesAPIService_FetchSites tests the FetchSites convenience method (read-only).
 func Test_deployment_services_SitesAPIService_FetchSites(t *testing.T) {
-	t.Skip("Skipping test: Sites model has non-pointer Id field (Id string), which causes issues with object creation as the API populates this field")
-
-	// Setup the authenticated client
 	client := SetupDeploymentSvcTestClient(t)
 
-	// Create test object using same payload as Create test
-	randomSuffix := common.GenerateRandomString(6)
-	testName := "test-site-fetch-" + randomSuffix
-
-	testObj := deployment_services.Sites{
-		Name: testName,
-		Id:   "", // Will be populated by API
-	}
-
-	createReq := client.SitesAPI.CreateSites(context.Background()).Sites(testObj)
-	createRes, _, err := createReq.Execute()
-	if err != nil {
-		handleAPIError(err)
-	}
-	require.NoError(t, err, "Failed to create test object for fetch test")
-	require.NotNil(t, createRes, "Create response should not be nil")
-	createdID := createRes.Id
-
-	// Cleanup after test
-	defer func() {
-		deleteReq := client.SitesAPI.DeleteSitesByID(context.Background(), createdID)
-		_, _ = deleteReq.Execute()
-		t.Logf("Cleaned up test object: %s", createdID)
-	}()
-
-	// Test 1: Fetch existing object by name
-	fetchedObj, err := client.SitesAPI.FetchSites(
-		context.Background(),
-		testName,
-		common.StringPtr("All"),
-		nil, // snippet
-		nil, // device
-	)
-
-	// Verify successful fetch
-	require.NoError(t, err, "Failed to fetch sites by name")
-	require.NotNil(t, fetchedObj, "Fetched object should not be nil")
-	assert.Equal(t, createdID, fetchedObj.Id, "Fetched object ID should match")
-	assert.Equal(t, testName, fetchedObj.Name, "Fetched object name should match")
-	t.Logf("[SUCCESS] FetchSites found object: %s", fetchedObj.Name)
-
-	// Test 2: Fetch non-existent object (should return nil, nil)
 	notFound, err := client.SitesAPI.FetchSites(
 		context.Background(),
-		"non-existent-sites-xyz-12345",
+		"non-existent-site-xyz-12345",
 		common.StringPtr("All"),
 		nil,
 		nil,

.idea/modules.xml

@@ -4,14 +4,29 @@ Identity Services Testing CertificatesAPIService
 package identity_services
 
 import (
+	"context"
 	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	"github.com/paloaltonetworks/scm-go/common"
 )
 
 // Test_identity_services_CertificatesAPIService_FetchCertificates tests the FetchCertificates convenience method
 func Test_identity_services_CertificatesAPIService_FetchCertificates(t *testing.T) {
-	// Note: Certificates API requires an existing CA (Certificate Authority) to sign new certificates.
-	// The 'signed_by' field must reference an existing CA name from TrustedCertificateAuthorities.
-	// Without a standardized/guaranteed CA name across environments, this test cannot reliably run.
-	// Python SDK (scm-python) also does not include tests for this API for the same reason.
-	t.Skip("Certificates API requires existing CA infrastructure - no standard CA name available across environments")
+	client := SetupIdentitySvcTestClient(t)
+
+	// Test: Fetch non-existent object (should return nil, nil)
+	// Cannot test positive path because Create requires existing CA infrastructure
+	notFound, err := client.CertificatesAPI.FetchCertificates(
+		context.Background(),
+		"non-existent-cert-xyz-12345",
+		common.StringPtr("Prisma Access"),
+		nil,
+		nil,
+	)
+	require.NoError(t, err, "Fetch should not error for non-existent object")
+	assert.Nil(t, notFound, "Should return nil for non-existent object")
+	t.Logf("[SUCCESS] FetchCertificates correctly returned nil for non-existent object")
 }