A Windows compatible version built with some added improvements.#12
Closed
Alb4don wants to merge 1 commit intoPanchajanya1999:masterfrom
Closed
A Windows compatible version built with some added improvements.#12Alb4don wants to merge 1 commit intoPanchajanya1999:masterfrom
Alb4don wants to merge 1 commit intoPanchajanya1999:masterfrom
Conversation
Alb4don
commented
Jan 14, 2026
- I found the project interesting and decided to contribute a little, especially for those who also use Windows. Considering the issue of DNS queries without external dependencies, I implemented direct communication via UDP socket with the DNS servers. I chose this approach because it works identically on Windows, Linux, and macOS, without the need for platform-specific tools like dig or nslookup.
- The original bash script used temporary files for inter-process communication, which works but creates race conditions, so I replaced that with proper concurrent data structures (Python's lock). Log write operations acquire a mutex before being written, ensuring that log files are not corrupted, even with 50 simultaneous operations.
- I also added an input sanitization layer. IP addresses are parsed by their respective libraries (ipaddress and the validate module in Python), which handles edge cases like leading zeros, shorthand notation, and malformed addresses well.
- Handling filenames for export is done using os.path.basename(), helping to avoid directory traversal attempts. I've seen many tools that blindly accept ../../../../etc/passwdum filenames as valid for output.
- It's important to mention that the correlation analysis combines DNS query times (70% weight) and network latency (30% weight) to identify servers that are fast at resolving and are close to you in terms of network connectivity. I chose these weights after testing several combinations.
- Finally, I performed some tests using Windows and Linux environments with different network configurations, and it worked well.

Owner
|
@Alb4don good work! i wrote it exclusively in shell because I handle servers which don't even have python installed, and shell does the exact thing without any big dependencies or installing a whole new language to just run a script. If you want to add Windows support, make sure you rewrite it as a batch file, which can run natively with as less as possible dependencies. I am closing this PR without merging. A new PR is much welcome with the above points in mind! I hope you get the point, have a nice day! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.