AssertionError in software_api() with custom PandA SW string in 0.10.4 (works in 0.10.3)

[zhulincqu]

Description

After upgrading pandablocks from 0.10.3 to 0.10.4, we started seeing an AssertionError during connect().

This issue does not occur in 0.10.3.

It appears that the new Identification dataclass introduced in 0.10.4 enforces a stricter version format in software_api(), which fails for MAX IV PandA firmware strings.

Error Traceback:

Traceback (most recent call last):
 File "/opt/conda/envs/sardana/lib/python3.11/site-packages/sardana_maxpeem/ctrl/MAXPEEMPandaBoxTGCtrl.py", line 49, in wrapper
 return func(self, *args, **kwargs)
 File "/opt/conda/envs/sardana/lib/python3.11/site-packages/sardana_maxpeem/ctrl/MAXPEEMPandaBoxTGCtrl.py", line 137, in __init__
 self.pandabox.connect()
 File "/opt/conda/envs/sardana/lib/python3.11/site-packages/pandablocks/blocking.py", line 58, in connect
 self._ctrl_connection.set_api(identification.software_api())
 File "/opt/conda/envs/sardana/lib/python3.11/site-packages/pandablocks/responses.py", line 374, in software_api
 assert match, (
AssertionError: PandA SW: maxiv20210331-151-ge4812f1 does not match expected pattern re.compile('^(\\d+).(\\d+)')

Environment

• pandablocks==0.10.4 (failing)
• pandablocks==0.10.3 (working)
• python==3.11

[coretl]

The problem is that certain commands have different behaviour depending on the version of PandABlocks-server. For example the table type added a MODE attribute in PandABlocks-server v4.0:

PandABlocks-client/src/pandablocks/commands.py

Line 704 in 8e4abde

has_mode=version >= (4, 0),

I'm happy to extend the regex to support + notation to allow other sites to append their own scheme. For instance python suggests
1.0+ubuntu-1 so you could tag as 4.0+maxiv20210331-151-ge4812f1 and get both bits of information in there

[zhulincqu]

Thanks a lot for the clarification. Your suggestion to support + notation sounds like a very clean and robust solution.