Merge pull request #1 from PandaTechAM/development

Bug fix on external interfaces

Author: HaikAsatryan

src/Analyzers/Analyzers.csproj

@@ -18,13 +18,13 @@
         <PackageId>Pandatech.Analyzers</PackageId>
         <PackageIcon>pandatech.png</PackageIcon>
         <PackageReadmeFile>Readme.md</PackageReadmeFile>
-        <Version>1.0.0</Version>
+        <Version>1.1.0</Version>
         <Authors>Pandatech</Authors>
         <Description>Pandatech Roslyn analyzers enforcing company coding rules.</Description>
         <PackageLicenseExpression>MIT</PackageLicenseExpression>
         <PackageTags>Pandatech, analyzers, roslyn, async, cancellation, coding-rules</PackageTags>
         <RepositoryUrl>https://github.com/PandaTechAM/be-lib-analyzers</RepositoryUrl>
-        <PackageReleaseNotes>Init</PackageReleaseNotes>
+        <PackageReleaseNotes>Bug fix on external interfaces</PackageReleaseNotes>
 
 
     </PropertyGroup>

src/Analyzers/Async/AsyncHelpers.cs

@@ -0,0 +1,42 @@
+using System.Linq;
+using Microsoft.CodeAnalysis;
+
+namespace Pandatech.Analyzers.Async;
+
+internal static class AsyncHelpers
+{
+   internal static bool IsContractImplementation(this IMethodSymbol method)
+   {
+      if (method.IsOverride)
+      {
+         return true;
+      }
+
+      if (!method.ExplicitInterfaceImplementations.IsEmpty)
+      {
+         return true;
+      }
+
+      var containingType = method.ContainingType;
+      if (containingType is null)
+      {
+         return false;
+      }
+
+      foreach (var member in containingType.AllInterfaces.SelectMany(iface => iface.GetMembers(method.Name)))
+      {
+         if (member is not IMethodSymbol ifaceMethod)
+         {
+            continue;
+         }
+
+         var implementation = containingType.FindImplementationForInterfaceMember(ifaceMethod);
+         if (SymbolEqualityComparer.Default.Equals(implementation, method))
+         {
+            return true;
+         }
+      }
+
+      return false;
+   }
+}

src/Analyzers/Async/AsyncMethodConventionsAnalyzer.cs

@@ -77,6 +77,24 @@ private static void AnalyzeMethod(SymbolAnalysisContext context)
          return;
       }
 
+      // Only analyze methods declared in source (skip metadata / external assemblies).
+      var hasSourceLocation = false;
+      foreach (var location in method.Locations)
+      {
+         if (!location.IsInSource)
+         {
+            continue;
+         }
+
+         hasSourceLocation = true;
+         break;
+      }
+
+      if (!hasSourceLocation)
+      {
+         return;
+      }
+
       if (method.ReturnType is not INamedTypeSymbol returnType)
       {
          return;
@@ -123,27 +141,42 @@ private static void AnalyzeAsyncMember(IMethodSymbol method,
       string displayName,
       Action<Diagnostic> report)
    {
-      // PT0001 – name must end with Async (for named methods).
+      var isContract = method.IsContractImplementation();
+
+      // PT0001 – name must end with Async (for named methods),
+      // but we DO NOT enforce it on contract implementations (MediatR Handle, overrides, etc.).
       if (!displayName.Equals("anonymous function", StringComparison.Ordinal) &&
-          !displayName.EndsWith("Async", StringComparison.Ordinal))
+          !displayName.EndsWith("Async", StringComparison.Ordinal) &&
+          !isContract)
       {
          report(Diagnostic.Create(AsyncSuffixRule, location, displayName));
       }
 
       var ctInfo = GetCancellationTokenInfo(method);
 
+      // PT0002 – missing CancellationToken
+      // Only enforced on non-contract methods (e.g. interface itself, normal class methods).
       if (!ctInfo.HasCt)
       {
-         report(Diagnostic.Create(CancellationTokenMissingRule, location, displayName));
+         if (!isContract)
+         {
+            report(Diagnostic.Create(CancellationTokenMissingRule, location, displayName));
+         }
+
          return;
       }
 
+      // PT0003 – name must be ct
+      // Always enforced when CT exists (both interface + implementation),
+      // so implementations still get "rename to ct".
       if (!ctInfo.IsNamedCt)
       {
          report(Diagnostic.Create(CancellationTokenNameRule, location, displayName, ctInfo.Name));
       }
 
-      if (!ctInfo.IsLast)
+      // PT0004 – CT must be last
+      // Only enforced on non-contract methods (interface / own class methods).
+      if (!ctInfo.IsLast && !isContract)
       {
          report(Diagnostic.Create(CancellationTokenPositionRule, location, displayName, ctInfo.Name));
       }