Skip to content

Commit 1d7634f

Browse files
committed
service response removal
1 parent 4ac29ae commit 1d7634f

File tree

3 files changed

+3
-45
lines changed

3 files changed

+3
-45
lines changed

src/ResponseCrafter/ApiExceptionHandler.cs

Lines changed: 0 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
using ResponseCrafter.Extensions;
1111
using ResponseCrafter.HttpExceptions;
1212
using ResponseCrafter.Options;
13-
using ServiceResponseCrafter.Dtos;
14-
using ServiceResponseCrafter.ExceptionHandler;
1513
using static ResponseCrafter.Helpers.ExceptionMessageBuilder;
1614
using IExceptionHandler = Microsoft.AspNetCore.Diagnostics.IExceptionHandler;
1715

@@ -56,9 +54,6 @@ public async ValueTask<bool> TryHandleAsync(HttpContext httpContext,
5654
case ImportException targetInvocationException:
5755
await HandleImportExceptionAsync(httpContext, targetInvocationException, cancellationToken);
5856
break;
59-
case ServiceException serviceException:
60-
await HandleServiceExceptionAsync(httpContext, serviceException, cancellationToken);
61-
break;
6257
case GridifyException gridifyException:
6358
await HandleGridifyExceptionAsync(httpContext, gridifyException, cancellationToken);
6459
break;
@@ -102,42 +97,6 @@ private async Task HandleImportExceptionAsync(HttpContext httpContext,
10297
}
10398
}
10499

105-
private async Task HandleServiceExceptionAsync(HttpContext httpContext,
106-
ServiceException serviceException,
107-
CancellationToken cancellationToken)
108-
{
109-
var originalMessage = serviceException.Message.ConvertCase(_convention);
110-
111-
var response = new ServiceResponse
112-
{
113-
Message = originalMessage,
114-
ResponseStatus = serviceException.ResponseStatus,
115-
Success = false
116-
};
117-
118-
httpContext.Response.StatusCode = (int)serviceException.ResponseStatus;
119-
120-
if (_visibility == "Public")
121-
{
122-
if (httpContext.Response.StatusCode >= 500)
123-
{
124-
response.Message = DefaultMessage.ConvertCase(_convention);
125-
}
126-
}
127-
128-
129-
if (httpContext.Response.StatusCode >= 500)
130-
{
131-
_logger.LogError("ServiceException encountered: {ExceptionMessage}", originalMessage);
132-
}
133-
else
134-
{
135-
_logger.LogWarning("ServiceException encountered: {ExceptionMessage}", originalMessage);
136-
}
137-
138-
await httpContext.Response.WriteAsJsonAsync(response, cancellationToken);
139-
}
140-
141100

142101
private async Task HandleGridifyExceptionAsync(HttpContext httpContext,
143102
GridifyException gridifyException,

src/ResponseCrafter/ResponseCrafter.csproj

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@
88
<Copyright>MIT</Copyright>
99
<PackageIcon>pandatech.png</PackageIcon>
1010
<PackageReadmeFile>Readme.md</PackageReadmeFile>
11-
<Version>5.0.3</Version>
11+
<Version>5.1.0</Version>
1212
<PackageId>Pandatech.ResponseCrafter</PackageId>
1313
<PackageTags>Pandatech, library, exception handler, exception, middleware, Api response</PackageTags>
1414
<Title>ResponseCrafter</Title>
1515
<Description>Handling exceptions, custom Dtos.</Description>
1616
<RepositoryUrl>https://github.com/PandaTechAM/be-lib-response-crafter</RepositoryUrl>
17-
<PackageReleaseNotes>Example value added</PackageReleaseNotes>
17+
<PackageReleaseNotes>ServiceResponse nuget support removal</PackageReleaseNotes>
1818
</PropertyGroup>
1919

2020
<ItemGroup>
@@ -28,7 +28,6 @@
2828
<PackageReference Include="Microsoft.AspNetCore.SignalR.Client" Version="9.0.0"/>
2929
<PackageReference Include="PandaTech.FluentImporter" Version="3.0.0"/>
3030
<PackageReference Include="Pandatech.GridifyExtensions" Version="2.0.0"/>
31-
<PackageReference Include="PandaTech.ServiceResponse" Version="2.0.2" />
3231
</ItemGroup>
3332

3433
</Project>

test/ResponseCrafter.Demo/ResponseCrafter.Demo.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
<ItemGroup>
1111
<PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="9.0.0" />
12-
<PackageReference Include="Swashbuckle.AspNetCore" Version="7.1.0" />
12+
<PackageReference Include="Swashbuckle.AspNetCore" Version="7.2.0" />
1313
</ItemGroup>
1414

1515
<ItemGroup>

0 commit comments

Comments
 (0)