Merge pull request #56 from PandaTechAM/development

logging performance boost

Author: HaikAsatryan

SharedKernel.Demo/appsettings.Development.json

@@ -3,8 +3,8 @@
     "MinimumLevel": {
       "Default": "Information",
       "Override": {
-        "Microsoft": "Warning",
-        "System": "Warning"
+        "Microsoft": "Information",
+        "System": "Information"
       }
     }
   },

src/SharedKernel/Logging/SerilogExtensions.cs

@@ -116,10 +116,11 @@ private static LoggerConfiguration WriteToFile(this LoggerConfiguration loggerCo
       if (useAsync)
       {
          return loggerConfig.WriteTo.Async(a =>
-            a.File(formatter,
-               logPath,
-               rollingInterval: RollingInterval.Day)
-         );
+               a.File(formatter,
+                  logPath,
+                  rollingInterval: RollingInterval.Day),
+            blockWhenFull: true,
+            bufferSize: 20_000);
       }
 
       return loggerConfig.WriteTo.File(formatter, logPath, rollingInterval: RollingInterval.Day);
@@ -129,59 +130,26 @@ private static LoggerConfiguration FilterOutUnwantedLogs(this LoggerConfiguratio
    {
       return loggerConfig
              .Filter
-             .ByExcluding(e => e.ShouldExcludeAboveBoardGetLogs()) 
+             .ByExcluding(e => e.ExcludeOutboxAndMassTransit())
              .Filter
-             .ByExcluding(e => e.ShouldExcludeHangfireDashboardLogs())
-             .Filter
-             .ByExcluding(e => e.ShouldExcludeOutboxDbCommandLogs())
-             .Filter
-             .ByExcluding(e => e.ShouldExcludeSwaggerLogs())
-             .Filter
-             .ByExcluding(e => e.ShouldExcludeMassTransitHealthCheckLogs());
-   }
-   
-   private static bool ShouldExcludeAboveBoardGetLogs(this LogEvent logEvent)
-   {
-      var path = logEvent.Properties.TryGetValue("RequestPath", out var p) && p is ScalarValue sv
-         ? sv.Value?.ToString()
-         : null;
-      
-      var method = logEvent.Properties.TryGetValue("RequestMethod", out var m) && m is ScalarValue mv
-         ? mv.Value?.ToString()
-         : null;
-
-      return string.Equals(method, "GET", StringComparison.OrdinalIgnoreCase)
-             && path?.StartsWith("/above-board", StringComparison.OrdinalIgnoreCase) == true;
-   }
-
-   private static bool ShouldExcludeHangfireDashboardLogs(this LogEvent logEvent)
-   {
-      return logEvent.Properties.TryGetValue("RequestPath", out var requestPathValue)
-             && requestPathValue is ScalarValue requestPath
-             && requestPath.Value
-                           ?.ToString()
-                           ?.Contains("/hangfire") == true;
+             .ByExcluding(evt =>
+             {
+                if (!evt.Properties.TryGetValue("RequestPath", out var p) || p is not ScalarValue sv)
+                   return false;
+                var path = sv.Value as string ?? "";
+                return path.StartsWith("/swagger")
+                       || path.StartsWith("/hangfire")
+                       || path.Contains("/above-board")
+                       || path.Contains("localhost/auth/is-authenticated.json?api-version=v2");
+             });
    }
 
-   private static bool ShouldExcludeOutboxDbCommandLogs(this LogEvent logEvent)
+   private static bool ExcludeOutboxAndMassTransit(this LogEvent logEvent)
    {
       var message = logEvent.RenderMessage();
-      return message.Contains("outbox_messages", StringComparison.OrdinalIgnoreCase);
-   }
-
-   private static bool ShouldExcludeSwaggerLogs(this LogEvent logEvent)
-   {
-      return logEvent.Properties.TryGetValue("RequestPath", out var requestPathValue)
-             && requestPathValue is ScalarValue requestPath
-             && requestPath.Value
-                           ?.ToString()
-                           ?.Contains("/swagger") == true;
-   }
-
-   private static bool ShouldExcludeMassTransitHealthCheckLogs(this LogEvent logEvent)
-   {
-      var message = logEvent.RenderMessage();
-      return message.StartsWith("Health check masstransit-bus with status Unhealthy completed after");
+      return message.Contains("outbox_messages", StringComparison.OrdinalIgnoreCase) || message.StartsWith(
+         "Health check masstransit-bus with status Unhealthy completed after",
+         StringComparison.OrdinalIgnoreCase);
    }
 
    private static string GetLogsPath(this WebApplicationBuilder builder)
@@ -194,5 +162,4 @@ private static string GetLogsPath(this WebApplicationBuilder builder)
       var fileName = $"logs-{instanceId}-.json";
       return Path.Combine(persistencePath, repoName, envName, "logs", fileName);
    }
-
 }

src/SharedKernel/SharedKernel.csproj

@@ -8,13 +8,13 @@
         <PackageReadmeFile>Readme.md</PackageReadmeFile>
         <Authors>Pandatech</Authors>
         <Copyright>MIT</Copyright>
-        <Version>1.5.1</Version>
+        <Version>1.5.2</Version>
         <PackageId>Pandatech.SharedKernel</PackageId>
         <Title>Pandatech Shared Kernel Library</Title>
         <PackageTags>Pandatech, shared kernel, library, OpenAPI, Swagger, utilities, scalar</PackageTags>
         <Description>Pandatech.SharedKernel provides centralized configurations, utilities, and extensions for ASP.NET Core projects. For more information refere to readme.md document.</Description>
         <RepositoryUrl>https://github.com/PandaTechAM/be-lib-sharedkernel</RepositoryUrl>
-        <PackageReleaseNotes>Logging cleanup and nuget updates</PackageReleaseNotes>
+        <PackageReleaseNotes>Logging performance boost</PackageReleaseNotes>
     </PropertyGroup>
 
     <ItemGroup>