fix up some SMTP mail code paths

setting to needed to be done in constructor
fixed up timing of setting attachadapter etc

Author: PandaWood

src/ExceptionReporter/Core/ExceptionReportInfo.cs

@@ -56,18 +56,18 @@ public void SetExceptions(IEnumerable<Exception> exceptions)
 		public bool SmtpUseSsl { get; set; }
 
 		/// <summary>
-		/// Email that is displayed in the 'Contact Information'. See <see cref="EmailReportAddress"/> 
+		/// Email that is displayed in the 'Contact Information'. /> 
 		/// for the email actually used to send if using SimpleMAPI or SMTP)
 		/// </summary>
 		public string ContactEmail { get; set; }
 
 		/// <summary>
-		/// The name of the running application using <see cref="Application.ProductName"/>
+		/// The name of the running application using />
 		/// </summary>
 		public string AppName { get; set; }
 
 		/// <summary>
-		/// The version of the running application using <see cref="Application.ProductVersion"/>
+		/// The version of the running application />
 		/// </summary>
 		public string AppVersion { get; set; }
 
@@ -77,7 +77,7 @@ public void SetExceptions(IEnumerable<Exception> exceptions)
 		public string RegionInfo { get; set; }
 
 		/// <summary>
-		/// The name of the running application's machine using <see cref="Environment.MachineName"/>
+		/// The name of the running application's machine/>
 		/// </summary>
 		public string MachineName { get; set; }
 

src/ExceptionReporter/ExceptionReportPresenter.cs

@@ -139,7 +139,7 @@ private void SendSmtpMail()
 			catch (Exception exception)
 			{
 				_view.SetEmailCompletedState(false);
-				_view.ShowErrorDialog("Unable to send email using SMTP", exception);
+				_view.ShowErrorDialog("Unable to send email using SMTP" + Environment.NewLine + exception.Message, exception);
 			}
 		}
 

src/ExceptionReporter/Mail/MailSender.cs

@@ -36,23 +36,20 @@ public void SendSmtp(string exceptionReport, CompletedMethodDelegate setEmailCom
 			};
 
 			var mailMessage = CreateMailMessage(exceptionReport);
-			_attacher = new AttachAdapter(mailMessage);
 
 			smtpClient.SendCompleted += delegate { setEmailCompletedState.Invoke(true); };
-			smtpClient.SendAsync(mailMessage, null);
+			smtpClient.SendAsync(mailMessage, "Exception Report");
 		}
 
 		private MailMessage CreateMailMessage(string exceptionReport)
 		{
-			var mailMessage = new MailMessage
+			var mailMessage = new MailMessage(_reportInfo.SmtpFromAddress, _reportInfo.EmailReportAddress)
 			{
 				BodyEncoding = Encoding.UTF8,
-				From = new MailAddress(_reportInfo.SmtpFromAddress, null),
 				Body = exceptionReport,
 				Subject = EmailSubject
 			};
-
-			mailMessage.To.Add(new MailAddress(_reportInfo.ContactEmail));
+			_attacher = new AttachAdapter(mailMessage);
 
 			if (_reportInfo.ScreenshotAvailable)
 				mailMessage.Attachments.Add(new Attachment(ScreenshotTaker.GetImageAsFile(_reportInfo.ScreenshotImage), ScreenshotTaker.ScreenshotMimeType));

src/WinFormsDemoApp/DemoAppView.cs

@@ -2,6 +2,7 @@
 using System.IO;
 using System.Windows.Forms;
 using ExceptionReporting;
+using ExceptionReporting.Core;
 
 namespace WinFormsDemoApp
 {
@@ -44,9 +45,26 @@ private static void Throw_CustomMessage_Click(object sender, EventArgs e)
 				// has to be a registered mime type, and be non-zero bytes, I believe (for MAPI at least) else it won't attach
 				File.WriteAllText(file1, "test text file 1");
 				File.WriteAllText(file2, "test text file 2");
+
 				var exceptionReporter = new ExceptionReporter();
+
 				exceptionReporter.Config.ShowAssembliesTab = false;
 				exceptionReporter.Config.FilesToAttach = new[] { file1, file2 };
+
+
+				//--- smtp
+//				exceptionReporter.Config.MailMethod = ExceptionReportInfo.EmailMethod.SMTP;
+//				exceptionReporter.Config.SmtpPort = 465;
+//				exceptionReporter.Config.SmtpServer= "smtp.gmail.com";
+//				exceptionReporter.Config.SmtpUsername = "<user>@gmail.com";
+//				exceptionReporter.Config.SmtpUseSsl = true;
+//				exceptionReporter.Config.SmtpPassword = "<password>";
+//				exceptionReporter.Config.SmtpFromAddress = "[email protected]";
+//
+//				exceptionReporter.Config.EmailReportAddress = "<user>@gmail.com";
+				//----
+
+
 				exceptionReporter.Show("This is a custom message. As another test, 2 temp files will be attached to the email sent", exception);
 			}
 		}
@@ -77,7 +95,7 @@ private static void ShowMultipleExceptionReporter()
 			exceptionReporter.Show(exception1, exception2);
 		}
 
-		private static void ShowExceptionReporter(bool useConfig) 
+		private static void ShowExceptionReporter(bool useSMTP) 
 		{
 			try
 			{