drop checkstyle

Author: Vincent Potucek

.github/actions/main-build/action.yml

@@ -4,7 +4,7 @@ inputs:
   arguments:
     required: true
     description: Gradle arguments
-    default: :platform-tooling-support-tests:test build --no-configuration-cache # Disable configuration cache due to https://github.com/diffplug/spotless/issues/2318
+    default: :platform-tooling-support-tests:test build
   encryptionKey:
     required: true
     description: Gradle cache encryption key

.github/workflows/cross-version.yml

@@ -60,8 +60,7 @@ jobs:
             -Ptesting.enableJaCoCo=false \
             -PjavaToolchain.version=${{ matrix.jdk.version }} \
             -Dscan.tag.JDK_${{ matrix.jdk.version }} \
-            build \
-            --no-configuration-cache #Disable configuration cache due to https://github.com/diffplug/spotless/issues/2318
+            build
       - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
         if: ${{ always() }}
         with:
@@ -102,8 +101,7 @@ jobs:
             -PjavaToolchain.implementation=j9 \
             -Dscan.tag.JDK_${{ matrix.jdk }} \
             -Dscan.tag.OpenJ9 \
-            build \
-            --no-configuration-cache # Disable configuration cache due to https://github.com/diffplug/spotless/issues/2318
+            build
       - uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
         if: ${{ always() }}
         with:

.github/workflows/main.yml

@@ -37,8 +37,7 @@ jobs:
         arguments: |
           :platform-tooling-support-tests:test \
           build \
-          jacocoRootReport \
-          --no-configuration-cache # Disable configuration cache due to https://github.com/diffplug/spotless/issues/2318
+          jacocoRootReport
     - name: Upload to Codecov.io
       uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
       with:

.github/workflows/release.yml

@@ -201,7 +201,6 @@ jobs:
           encryptionKey: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
           arguments: |
             --no-build-cache \
-            --no-configuration-cache \
             clean \
             gitPublishCopy \
             -Pdocumentation.replaceCurrentDocs=${{ contains(inputs.releaseVersion, '-') && 'false' || 'true' }}
@@ -215,7 +214,6 @@ jobs:
           encryptionKey: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
           arguments: |
             --no-build-cache \
-            --no-configuration-cache \
             gitPublishPush \
             -Pdocumentation.replaceCurrentDocs=${{ contains(inputs.releaseVersion, '-') && 'false' || 'true' }}
       - name: Wait for deployment to GitHub Pages

.github/workflows/reproducible-build.yml

@@ -28,8 +28,7 @@ jobs:
       with:
         encryptionKey: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
         arguments: |
-          --quiet \
-          --no-configuration-cache # Disable configuration cache due to https://github.com/diffplug/spotless/issues/2318
+          --quiet
     - name: Build and compare checksums
       shell: bash
       run: ./.github/scripts/checkBuildReproducibility.sh

CONTRIBUTING.md

@@ -72,22 +72,18 @@ Whenever an acronym is included as part of a field name or parameter name:
 - Otherwise, keep the first letter of the acronym uppercase and use lowercase for the
   rest of the acronym -- for example, `String defaultUrl;`.
 
-### Formatting
-
-#### Code
-
-Code formatting is enforced using the [Spotless](https://github.com/diffplug/spotless)
-Gradle plugin. You can use `gradle spotlessApply` to format new code and add missing
-license headers to source files. Formatter and import order settings for Eclipse are
-available in the repository under
-[junit-eclipse-formatter-settings.xml](gradle/config/eclipse/junit-eclipse-formatter-settings.xml)
-and [junit-eclipse.importorder](gradle/config/eclipse/junit-eclipse.importorder),
-respectively. For IntelliJ IDEA there's a
-[plugin](https://plugins.jetbrains.com/plugin/6546) you can use in conjunction with the
-Eclipse settings.
-
-It is forbidden to use _wildcard imports_ (e.g., `import static org.junit.jupiter.api.Assertions.*;`)
-in Java code.
+### 🚀 Code Convention & Transformation
+*(Advanced Refactoring, Modernization, and Bulk Code Changes)*
+
+#### 🔧 Automated rewriting of source code to
+- **Refactor** safely (e.g., rename methods, migrate APIs)
+- **Modernize** (e.g., Java 8 → Java 17 features)
+- **Fix anti-patterns** (e.g., replace `Vector` with `ArrayList`)
+- **Enforce conventions** (e.g., JUnit's naming rules)
+
+The build system incorporates [Moderne](https://moderne.io/) rewrite capabilities for automated code transformations. These modifications are environment-driven enlisted in the [junitbuild.java-library-conventions.gradle.kts](gradle/plugins/common/src/main/kotlin/junitbuild.java-library-conventions.gradle.kts)
+
+You can use `gradle rewriteRun` to apply these changes.
 
 #### Documentation
 

RELEASING.md

@@ -7,7 +7,7 @@
 - [ ] Change release date in Release Notes
 - [ ] Change release date in `README.MD`
 - [ ] Commit with message "Release ${VERSION}"
-- [ ] Execute `./gradlew --no-build-cache --no-configuration-cache clean build jreleaserDeploy`
+- [ ] Execute `./gradlew --no-build-cache clean build jreleaserDeploy`
 - [ ] Tag current commit: `git tag -s -m ${VERSION} r${VERSION}`
 - [ ] Change `version` in `gradle.properties` on release branch to new development versions and commit with message "Back to snapshots for further development" or similar
 - [ ] Push release branch and tag to GitHub: `git push --set-upstream --follow-tags origin HEAD`

build.gradle.kts

@@ -3,7 +3,6 @@ import junitbuild.extensions.dependencyProject
 plugins {
 	id("junitbuild.base-conventions")
 	id("junitbuild.build-metadata")
-	id("junitbuild.checkstyle-nohttp")
 	id("junitbuild.jacoco-aggregation-conventions")
 	id("junitbuild.maven-central-publishing")
 	id("junitbuild.temp-maven-repo")
@@ -15,7 +14,7 @@ group = "org.junit"
 val license by extra(License(
 	name = "Eclipse Public License v2.0",
 	url = uri("https://www.eclipse.org/legal/epl-v20.html"),
-	headerFile = layout.projectDirectory.file("gradle/config/spotless/eclipse-public-license-2.0.java")
+	headerFile = layout.projectDirectory.file("gradle/config/license/eclipse-public-license-2.0.java")
 ))
 
 val platformProjects by extra(listOf(

documentation/documentation.gradle.kts

@@ -210,10 +210,6 @@ tasks {
 		options.release.set(21)
 	}
 
-	named<Checkstyle>("checkstyleTools") {
-		config = resources.text.fromFile(checkstyle.configDirectory.file("checkstyleMain.xml"))
-	}
-
 	val generateConsoleLauncherOptions by registering(CaptureJavaExecOutput::class) {
 		classpath.from(standaloneConsoleLauncherClasspath)
 		mainClass = "org.junit.platform.console.ConsoleLauncher"

documentation/src/test/java/example/ClassTemplateDemo.java

@@ -52,9 +52,9 @@ void wellKnown() {
 	}
 
 	// end::user_guide[]
-	static
+	public
 	// tag::user_guide[]
-	public class MyClassTemplateInvocationContextProvider
+	static class MyClassTemplateInvocationContextProvider
 			// tag::custom_line_break[]
 			implements ClassTemplateInvocationContextProvider {