Add CleanupAssertions spring-projects#5193 spring-projects#5002

Vincent Potucek · Vincent Potucek · commit b2f5ccc9b96e · 2025-12-15T13:04:02.000+01:00
- https://docs.openrewrite.org/recipes/java/testing/junit/jupiterbestpractices Signed-off-by: Vincent Potucek <vpotucek@me.com>
diff --git a/buildSrc/src/main/java/org/springframework/boot/build/DeployedPlugin.java b/buildSrc/src/main/java/org/springframework/boot/build/DeployedPlugin.java
@@ -47,14 +47,14 @@ public void apply(Project project) {
 		project.afterEvaluate((evaluated) -> project.getPlugins().withType(JavaPlugin.class).all((javaPlugin) -> {
 			if (((Jar) project.getTasks().getByName(JavaPlugin.JAR_TASK_NAME)).isEnabled()) {
 				project.getComponents()
-					.matching((component) -> component.getName().equals("java"))
+					.matching((component) -> "java".equals(component.getName()))
 					.all(mavenPublication::from);
 			}
 		}));
 		project.getPlugins()
 			.withType(JavaPlatformPlugin.class)
 			.all((javaPlugin) -> project.getComponents()
-				.matching((component) -> component.getName().equals("javaPlatform"))
+				.matching((component) -> "javaPlatform".equals(component.getName()))
 				.all(mavenPublication::from));
 	}
 
diff --git a/buildSrc/src/main/java/org/springframework/boot/build/MavenRepositoryPlugin.java b/buildSrc/src/main/java/org/springframework/boot/build/MavenRepositoryPlugin.java
@@ -62,10 +62,10 @@ public void apply(Project project) {
 			mavenRepository.setUrl(repositoryLocation.toURI());
 		});
 		project.getTasks()
-			.matching((task) -> task.getName().equals(PUBLISH_TO_PROJECT_REPOSITORY_TASK_NAME))
+			.matching((task) -> PUBLISH_TO_PROJECT_REPOSITORY_TASK_NAME.equals(task.getName()))
 			.all((task) -> setUpProjectRepository(project, task, repositoryLocation));
 		project.getTasks()
-			.matching((task) -> task.getName().equals("publishPluginMavenPublicationToProjectRepository"))
+			.matching((task) -> "publishPluginMavenPublicationToProjectRepository".equals(task.getName()))
 			.all((task) -> setUpProjectRepository(project, task, repositoryLocation));
 	}
 
diff --git a/buildSrc/src/main/java/org/springframework/boot/build/antora/CheckJavadocMacros.java b/buildSrc/src/main/java/org/springframework/boot/build/antora/CheckJavadocMacros.java
@@ -336,7 +336,7 @@ private WellKnownAnchor(Origin origin) {
 		}
 
 		private static WellKnownAnchor of(String anchor, Origin origin) {
-			if (anchor.equals("enum-constant-summary")) {
+			if ("enum-constant-summary".equals(anchor)) {
 				return new WellKnownAnchor(origin);
 			}
 			return null;
diff --git a/buildSrc/src/main/java/org/springframework/boot/build/architecture/AutoConfigurationChecker.java b/buildSrc/src/main/java/org/springframework/boot/build/architecture/AutoConfigurationChecker.java
@@ -117,7 +117,7 @@ private JavaClass[] getImportedClasses(JavaClass javaClass) {
 
 		private boolean isBootClass(JavaClass javaClass) {
 			String pkg = javaClass.getPackage().getName();
-			return pkg.equals(SPRING_BOOT_ROOT_PACKAGE) || pkg.startsWith(SPRING_BOOT_ROOT_PACKAGE + ".");
+			return SPRING_BOOT_ROOT_PACKAGE.equals(pkg) || pkg.startsWith(SPRING_BOOT_ROOT_PACKAGE + ".");
 		}
 
 	}
diff --git a/buildSrc/src/main/java/org/springframework/boot/build/bom/bomr/StandardLibraryUpdateResolver.java b/buildSrc/src/main/java/org/springframework/boot/build/bom/bomr/StandardLibraryUpdateResolver.java
@@ -74,7 +74,7 @@ public List<LibraryWithVersionOptions> findLibraryUpdates(Collection<Library> li
 	}
 
 	protected boolean isLibraryExcluded(Library library) {
-		return library.getName().equals("Spring Boot");
+		return "Spring Boot".equals(library.getName());
 	}
 
 	protected List<VersionOption> getVersionOptions(Library library) {
diff --git a/buildSrc/src/main/java/org/springframework/boot/build/classpath/CheckClasspathForProhibitedDependencies.java b/buildSrc/src/main/java/org/springframework/boot/build/classpath/CheckClasspathForProhibitedDependencies.java
@@ -85,7 +85,7 @@ private boolean prohibited(ModuleVersionIdentifier id) {
 	}
 
 	private boolean prohibitedSlf4j(ModuleVersionIdentifier id) {
-		return id.getGroup().equals("org.slf4j") && id.getName().equals("jcl-over-slf4j");
+		return "org.slf4j".equals(id.getGroup()) && "jcl-over-slf4j".equals(id.getName());
 	}
 
 	private boolean prohibitedJbossSpec(ModuleVersionIdentifier id) {
diff --git a/buildSrc/src/main/java/org/springframework/boot/build/starters/DocumentStarters.java b/buildSrc/src/main/java/org/springframework/boot/build/starters/DocumentStarters.java
@@ -139,7 +139,7 @@ private Starter(String name, String description, Set<String> dependencies) {
 		}
 
 		private boolean isProduction() {
-			return this.name.equals("spring-boot-starter-actuator");
+			return "spring-boot-starter-actuator".equals(this.name);
 		}
 
 		private boolean isTechnical() {
diff --git a/buildSrc/src/test/java/org/springframework/boot/build/ConventionsPluginTests.java b/buildSrc/src/test/java/org/springframework/boot/build/ConventionsPluginTests.java
@@ -70,7 +70,7 @@ void setup(@TempDir File projectDir) throws IOException {
 	}
 
 	@Test
-	void jarIncludesLegalFiles() throws IOException {
+	void jarIncludesLegalFiles() throws Exception {
 		try (PrintWriter out = new PrintWriter(new FileWriter(this.buildFile))) {
 			out.println("plugins {");
 			out.println("    id 'java'");
@@ -101,7 +101,7 @@ void jarIncludesLegalFiles() throws IOException {
 	}
 
 	@Test
-	void sourceJarIsBuilt() throws IOException {
+	void sourceJarIsBuilt() throws Exception {
 		try (PrintWriter out = new PrintWriter(new FileWriter(this.buildFile))) {
 			out.println("plugins {");
 			out.println("    id 'java'");
@@ -132,7 +132,7 @@ void sourceJarIsBuilt() throws IOException {
 	}
 
 	@Test
-	void javadocJarIsBuilt() throws IOException {
+	void javadocJarIsBuilt() throws Exception {
 		try (PrintWriter out = new PrintWriter(new FileWriter(this.buildFile))) {
 			out.println("plugins {");
 			out.println("    id 'java'");
@@ -176,7 +176,7 @@ private void assertThatNoticeIsPresent(JarFile jar) throws IOException {
 	}
 
 	@Test
-	void testRetryIsConfiguredWithThreeRetriesOnCI() throws IOException {
+	void retryIsConfiguredWithThreeRetriesOnCI() throws Exception {
 		try (PrintWriter out = new PrintWriter(new FileWriter(this.buildFile))) {
 			out.println("plugins {");
 			out.println("    id 'java'");
@@ -198,7 +198,7 @@ void testRetryIsConfiguredWithThreeRetriesOnCI() throws IOException {
 	}
 
 	@Test
-	void testRetryIsConfiguredWithZeroRetriesLocally() throws IOException {
+	void retryIsConfiguredWithZeroRetriesLocally() throws Exception {
 		try (PrintWriter out = new PrintWriter(new FileWriter(this.buildFile))) {
 			out.println("plugins {");
 			out.println("    id 'java'");
diff --git a/buildSrc/src/test/java/org/springframework/boot/build/autoconfigure/DocumentAutoConfigurationClassesTests.java b/buildSrc/src/test/java/org/springframework/boot/build/autoconfigure/DocumentAutoConfigurationClassesTests.java
@@ -43,7 +43,7 @@ class DocumentAutoConfigurationClassesTests {
 	private File temp;
 
 	@Test
-	void classesAreDocumented() throws IOException {
+	void classesAreDocumented() throws Exception {
 		File output = documentAutoConfigurationClasses((metadataDir) -> {
 			writeAutoConfigurationMetadata("spring-boot-one", List.of("org.springframework.boot.one.AAutoConfiguration",
 					"org.springframework.boot.one.BAutoConfiguration"), metadataDir);
@@ -56,7 +56,7 @@ void classesAreDocumented() throws IOException {
 	}
 
 	@Test
-	void whenMetadataIsRemovedThenOutputForThatMetadataIsNoLongerPresent() throws IOException {
+	void whenMetadataIsRemovedThenOutputForThatMetadataIsNoLongerPresent() throws Exception {
 		documentAutoConfigurationClasses((metadataDir) -> {
 			writeAutoConfigurationMetadata("spring-boot-one", List.of("org.springframework.boot.one.AAutoConfiguration",
 					"org.springframework.boot.one.BAutoConfiguration"), metadataDir);
diff --git a/buildSrc/src/test/java/org/springframework/boot/build/bom/BomPluginIntegrationTests.java b/buildSrc/src/test/java/org/springframework/boot/build/bom/BomPluginIntegrationTests.java
@@ -18,7 +18,6 @@
 
 import java.io.File;
 import java.io.FileWriter;
-import java.io.IOException;
 import java.io.PrintWriter;
 import java.util.function.Consumer;
 
@@ -51,7 +50,7 @@ void setup(@TempDir File projectDir) {
 	}
 
 	@Test
-	void libraryModulesAreIncludedInDependencyManagementOfGeneratedPom() throws IOException {
+	void libraryModulesAreIncludedInDependencyManagementOfGeneratedPom() throws Exception {
 		try (PrintWriter out = new PrintWriter(new FileWriter(this.buildFile))) {
 			out.println("plugins {");
 			out.println("    id 'org.springframework.boot.bom'");
@@ -88,7 +87,7 @@ void libraryModulesAreIncludedInDependencyManagementOfGeneratedPom() throws IOEx
 	}
 
 	@Test
-	void libraryPluginsAreIncludedInPluginManagementOfGeneratedPom() throws IOException {
+	void libraryPluginsAreIncludedInPluginManagementOfGeneratedPom() throws Exception {
 		try (PrintWriter out = new PrintWriter(new FileWriter(this.buildFile))) {
 			out.println("plugins {");
 			out.println("    id 'org.springframework.boot.bom'");
@@ -143,7 +142,7 @@ void libraryImportsAreIncludedInDependencyManagementOfGeneratedPom() throws Exce
 	}
 
 	@Test
-	void moduleExclusionsAreIncludedInDependencyManagementOfGeneratedPom() throws IOException {
+	void moduleExclusionsAreIncludedInDependencyManagementOfGeneratedPom() throws Exception {
 		try (PrintWriter out = new PrintWriter(new FileWriter(this.buildFile))) {
 			out.println("plugins {");
 			out.println("    id 'org.springframework.boot.bom'");
@@ -177,7 +176,7 @@ void moduleExclusionsAreIncludedInDependencyManagementOfGeneratedPom() throws IO
 	}
 
 	@Test
-	void moduleTypesAreIncludedInDependencyManagementOfGeneratedPom() throws IOException {
+	void moduleTypesAreIncludedInDependencyManagementOfGeneratedPom() throws Exception {
 		try (PrintWriter out = new PrintWriter(new FileWriter(this.buildFile))) {
 			out.println("plugins {");
 			out.println("    id 'org.springframework.boot.bom'");
@@ -209,7 +208,7 @@ void moduleTypesAreIncludedInDependencyManagementOfGeneratedPom() throws IOExcep
 	}
 
 	@Test
-	void moduleClassifiersAreIncludedInDependencyManagementOfGeneratedPom() throws IOException {
+	void moduleClassifiersAreIncludedInDependencyManagementOfGeneratedPom() throws Exception {
 		try (PrintWriter out = new PrintWriter(new FileWriter(this.buildFile))) {
 			out.println("plugins {");
 			out.println("    id 'org.springframework.boot.bom'");
@@ -268,7 +267,7 @@ void moduleClassifiersAreIncludedInDependencyManagementOfGeneratedPom() throws I
 	}
 
 	@Test
-	void libraryNamedSpringBootHasNoVersionProperty() throws IOException {
+	void libraryNamedSpringBootHasNoVersionProperty() throws Exception {
 		try (PrintWriter out = new PrintWriter(new FileWriter(this.buildFile))) {
 			out.println("plugins {");
 			out.println("    id 'org.springframework.boot.bom'");
diff --git a/buildSrc/src/test/java/org/springframework/boot/build/bom/bomr/UpgradeApplicatorTests.java b/buildSrc/src/test/java/org/springframework/boot/build/bom/bomr/UpgradeApplicatorTests.java
@@ -18,7 +18,6 @@
 
 import java.io.File;
 import java.io.FileInputStream;
-import java.io.IOException;
 import java.io.InputStream;
 import java.nio.file.Files;
 import java.util.Collections;
@@ -46,7 +45,7 @@ class UpgradeApplicatorTests {
 	File temp;
 
 	@Test
-	void whenUpgradeIsAppliedToLibraryWithVersionThenBomIsUpdated() throws IOException {
+	void whenUpgradeIsAppliedToLibraryWithVersionThenBomIsUpdated() throws Exception {
 		File bom = new File(this.temp, "bom.gradle");
 		FileCopyUtils.copy(new File("src/test/resources/bom.gradle"), bom);
 		String originalContents = Files.readString(bom.toPath());
@@ -61,7 +60,7 @@ void whenUpgradeIsAppliedToLibraryWithVersionThenBomIsUpdated() throws IOExcepti
 	}
 
 	@Test
-	void whenUpgradeIsAppliedToLibraryWithVersionPropertyThenGradlePropertiesIsUpdated() throws IOException {
+	void whenUpgradeIsAppliedToLibraryWithVersionPropertyThenGradlePropertiesIsUpdated() throws Exception {
 		File bom = new File(this.temp, "bom.gradle");
 		FileCopyUtils.copy(new File("src/test/resources/bom.gradle"), bom);
 		File gradleProperties = new File(this.temp, "gradle.properties");
diff --git a/buildSrc/src/test/java/org/springframework/boot/build/context/properties/ConfigurationPropertiesAnalyzerTests.java b/buildSrc/src/test/java/org/springframework/boot/build/context/properties/ConfigurationPropertiesAnalyzerTests.java
@@ -46,7 +46,7 @@ void createAnalyzerWithNoSource() {
 	}
 
 	@Test
-	void analyzeSortWithAlphabeticalOrder(@TempDir File tempDir) throws IOException {
+	void analyzeSortWithAlphabeticalOrder(@TempDir File tempDir) throws Exception {
 		File metadata = new File(tempDir, "metadata.json");
 		Files.writeString(metadata.toPath(), """
 				{ "properties": [
@@ -62,7 +62,7 @@ void analyzeSortWithAlphabeticalOrder(@TempDir File tempDir) throws IOException
 	}
 
 	@Test
-	void analyzeSortWithViolations(@TempDir File tempDir) throws IOException {
+	void analyzeSortWithViolations(@TempDir File tempDir) throws Exception {
 		File metadata = new File(tempDir, "metadata.json");
 		Files.writeString(metadata.toPath(), """
 				{ "properties": [
@@ -80,7 +80,7 @@ void analyzeSortWithViolations(@TempDir File tempDir) throws IOException {
 	}
 
 	@Test
-	void analyzePropertyDescription(@TempDir File tempDir) throws IOException {
+	void analyzePropertyDescription(@TempDir File tempDir) throws Exception {
 		File metadata = new File(tempDir, "metadata.json");
 		Files.writeString(metadata.toPath(), """
 				{ "properties": [
@@ -98,7 +98,7 @@ void analyzePropertyDescription(@TempDir File tempDir) throws IOException {
 	}
 
 	@Test
-	void analyzePropertyDescriptionWithMissingDescription(@TempDir File tempDir) throws IOException {
+	void analyzePropertyDescriptionWithMissingDescription(@TempDir File tempDir) throws Exception {
 		File metadata = new File(tempDir, "metadata.json");
 		Files.writeString(metadata.toPath(), """
 				{ "properties": [
@@ -116,7 +116,7 @@ void analyzePropertyDescriptionWithMissingDescription(@TempDir File tempDir) thr
 	}
 
 	@Test
-	void analyzeDeprecatedPropertyWithMissingSince(@TempDir File tempDir) throws IOException {
+	void analyzeDeprecatedPropertyWithMissingSince(@TempDir File tempDir) throws Exception {
 		File metadata = new File(tempDir, "metadata.json");
 		Files.writeString(metadata.toPath(), """
 				{ "properties": [
@@ -142,12 +142,12 @@ void analyzeDeprecatedPropertyWithMissingSince(@TempDir File tempDir) throws IOE
 	}
 
 	@Test
-	void writeEmptyReport(@TempDir File tempDir) throws IOException {
+	void writeEmptyReport(@TempDir File tempDir) throws Exception {
 		assertThat(writeToFile(tempDir, new Report(tempDir))).hasContent("No problems found.");
 	}
 
 	@Test
-	void writeReportWithNoProblemsFound(@TempDir File tempDir) throws IOException {
+	void writeReportWithNoProblemsFound(@TempDir File tempDir) throws Exception {
 		Report report = new Report(tempDir);
 		File first = new File(tempDir, "metadata-1.json");
 		report.registerAnalysis(first, new Analysis("Check for things:"));
@@ -163,7 +163,7 @@ void writeReportWithNoProblemsFound(@TempDir File tempDir) throws IOException {
 	}
 
 	@Test
-	void writeReportWithOneProblem(@TempDir File tempDir) throws IOException {
+	void writeReportWithOneProblem(@TempDir File tempDir) throws Exception {
 		Report report = new Report(tempDir);
 		File metadata = new File(tempDir, "metadata-1.json");
 		Analysis analysis = new Analysis("Check for things:");
@@ -181,7 +181,7 @@ void writeReportWithOneProblem(@TempDir File tempDir) throws IOException {
 	}
 
 	@Test
-	void writeReportWithSeveralProblems(@TempDir File tempDir) throws IOException {
+	void writeReportWithSeveralProblems(@TempDir File tempDir) throws Exception {
 		Report report = new Report(tempDir);
 		File metadata = new File(tempDir, "metadata-1.json");
 		Analysis firstAnalysis = new Analysis("Check for things:");
diff --git a/buildSrc/src/test/java/org/springframework/boot/build/optional/OptionalDependenciesPluginIntegrationTests.java b/buildSrc/src/test/java/org/springframework/boot/build/optional/OptionalDependenciesPluginIntegrationTests.java
@@ -47,7 +47,7 @@ void setup(@TempDir File projectDir) {
 	}
 
 	@Test
-	void optionalConfigurationIsCreated() throws IOException {
+	void optionalConfigurationIsCreated() throws Exception {
 		try (PrintWriter out = new PrintWriter(new FileWriter(this.buildFile))) {
 			out.println("plugins { id 'org.springframework.boot.optional-dependencies' }");
 			out.println("task printConfigurations {");
@@ -61,22 +61,22 @@ void optionalConfigurationIsCreated() throws IOException {
 	}
 
 	@Test
-	void optionalDependenciesAreAddedToMainSourceSetsCompileClasspath() throws IOException {
+	void optionalDependenciesAreAddedToMainSourceSetsCompileClasspath() throws Exception {
 		optionalDependenciesAreAddedToSourceSetClasspath("main", "compileClasspath");
 	}
 
 	@Test
-	void optionalDependenciesAreAddedToMainSourceSetsRuntimeClasspath() throws IOException {
+	void optionalDependenciesAreAddedToMainSourceSetsRuntimeClasspath() throws Exception {
 		optionalDependenciesAreAddedToSourceSetClasspath("main", "runtimeClasspath");
 	}
 
 	@Test
-	void optionalDependenciesAreAddedToTestSourceSetsCompileClasspath() throws IOException {
+	void optionalDependenciesAreAddedToTestSourceSetsCompileClasspath() throws Exception {
 		optionalDependenciesAreAddedToSourceSetClasspath("test", "compileClasspath");
 	}
 
 	@Test
-	void optionalDependenciesAreAddedToTestSourceSetsRuntimeClasspath() throws IOException {
+	void optionalDependenciesAreAddedToTestSourceSetsRuntimeClasspath() throws Exception {
 		optionalDependenciesAreAddedToSourceSetClasspath("test", "runtimeClasspath");
 	}
 
diff --git a/buildSrc/src/test/java/org/springframework/boot/build/test/autoconfigure/TestSliceMetadataTests.java b/buildSrc/src/test/java/org/springframework/boot/build/test/autoconfigure/TestSliceMetadataTests.java
@@ -31,7 +31,7 @@
  *
  * @author Andy Wilkinson
  */
-public class TestSliceMetadataTests {
+class TestSliceMetadataTests {
 
 	@TempDir
 	private File temp;

Original file line number	Diff line number	Diff line change
`@@ -336,7 +336,7 @@ private WellKnownAnchor(Origin origin) {`
`336`	`336`	`}`
`337`	`337`
`338`	`338`	`private static WellKnownAnchor of(String anchor, Origin origin) {`
`339`		`- if (anchor.equals("enum-constant-summary")) {`
	`339`	`+ if ("enum-constant-summary".equals(anchor)) {`
`340`	`340`	`return new WellKnownAnchor(origin);`
`341`	`341`	`}`
`342`	`342`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ private JavaClass[] getImportedClasses(JavaClass javaClass) {`
`117`	`117`
`118`	`118`	`private boolean isBootClass(JavaClass javaClass) {`
`119`	`119`	`String pkg = javaClass.getPackage().getName();`
`120`		`- return pkg.equals(SPRING_BOOT_ROOT_PACKAGE) \|\| pkg.startsWith(SPRING_BOOT_ROOT_PACKAGE + ".");`
	`120`	`+ return SPRING_BOOT_ROOT_PACKAGE.equals(pkg) \|\| pkg.startsWith(SPRING_BOOT_ROOT_PACKAGE + ".");`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`}`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ public List<LibraryWithVersionOptions> findLibraryUpdates(Collection<Library> li`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`protected boolean isLibraryExcluded(Library library) {`
`77`		`- return library.getName().equals("Spring Boot");`
	`77`	`+ return "Spring Boot".equals(library.getName());`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`protected List<VersionOption> getVersionOptions(Library library) {`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ private boolean prohibited(ModuleVersionIdentifier id) {`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`private boolean prohibitedSlf4j(ModuleVersionIdentifier id) {`
`88`		`- return id.getGroup().equals("org.slf4j") && id.getName().equals("jcl-over-slf4j");`
	`88`	`+ return "org.slf4j".equals(id.getGroup()) && "jcl-over-slf4j".equals(id.getName());`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`private boolean prohibitedJbossSpec(ModuleVersionIdentifier id) {`
Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ private Starter(String name, String description, Set<String> dependencies) {`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`private boolean isProduction() {`
`142`		`- return this.name.equals("spring-boot-starter-actuator");`
	`142`	`+ return "spring-boot-starter-actuator".equals(this.name);`
`143`	`143`	`}`
`144`	`144`
`145`	`145`	`private boolean isTechnical() {`