BeaconDeactivatedEvent called during chunk unloads

[electronicboy]

java.lang.IllegalStateException: Cannot update ticket level while unloading chunks or updating entity manager
	at io.papermc.paper.chunk.system.scheduling.ChunkHolderManager.processTicketUpdates(ChunkHolderManager.java:932) ~[paper-1.19.2.jar:git-Paper-307]
	at io.papermc.paper.chunk.system.scheduling.ChunkHolderManager.processTicketUpdates(ChunkHolderManager.java:919) ~[paper-1.19.2.jar:git-Paper-307]
	at io.papermc.paper.chunk.system.scheduling.ChunkTaskScheduler.scheduleTickingState(ChunkTaskScheduler.java:293) ~[paper-1.19.2.jar:git-Paper-307]
	at io.papermc.paper.chunk.system.scheduling.ChunkTaskScheduler.scheduleChunkLoad(ChunkTaskScheduler.java:399) ~[paper-1.19.2.jar:git-Paper-307]
	at net.minecraft.server.level.ServerChunkCache.getChunkFutureMainThread(ServerChunkCache.java:533) ~[?:?]
	at net.minecraft.server.level.ServerChunkCache.getChunk(ServerChunkCache.java:440) ~[?:?]
	at net.minecraft.world.level.Level.getChunk(Level.java:502) ~[?:?]
	at net.minecraft.world.level.Level.getBlockState(Level.java:780) ~[?:?]
	at org.bukkit.craftbukkit.v1_19_R1.block.CraftBlock.getType(CraftBlock.java:227) ~[paper-1.19.2.jar:git-Paper-307]
	at io.papermc.paper.event.block.BeaconDeactivatedEvent.getBeacon(BeaconDeactivatedEvent.java:30) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
	at com.togiko.minecraft.plugins.beaconPlugin.events.ModifiedBeacon.onBeaconDeactivate(ModifiedBeacon.java:95) ~[minecraft-beacon-plugin-1.0.0.jar:?]
	at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor4.execute(Unknown Source) ~[?:?]
	at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
	at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:git-Paper-307]
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:670) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.event.Event.callEvent(Event.java:45) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?]
	at net.minecraft.world.level.block.entity.BeaconBlockEntity.setRemoved(BeaconBlockEntity.java:281) ~[?:?]
	at java.util.HashMap$Values.forEach(HashMap.java:1065) ~[?:?]
	at net.minecraft.world.level.chunk.LevelChunk.clearAllBlockEntities(LevelChunk.java:1156) ~[?:?]
	at net.minecraft.server.level.ServerLevel.unload(ServerLevel.java:1520) ~[?:?]
	at io.papermc.paper.chunk.system.scheduling.NewChunkHolder.unloadStage2(NewChunkHolder.java:821) ~[paper-1.19.2.jar:git-Paper-307]
	at io.papermc.paper.chunk.system.scheduling.ChunkHolderManager.processUnloads(ChunkHolderManager.java:874) ~[paper-1.19.2.jar:git-Paper-307]
	at net.minecraft.server.level.ChunkMap.processUnloads(ChunkMap.java:630) ~[paper-1.19.2.jar:git-Paper-307]
	at net.minecraft.server.level.ChunkMap.tick(ChunkMap.java:618) ~[paper-1.19.2.jar:git-Paper-307]
	at net.minecraft.server.level.ServerChunkCache.tick(ServerChunkCache.java:654) ~[?:?]
	at net.minecraft.server.level.ServerLevel.tick(ServerLevel.java:686) ~[?:?]
	at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1535) ~[paper-1.19.2.jar:git-Paper-307]
	at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:446) ~[paper-1.19.2.jar:git-Paper-307]
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1397) ~[paper-1.19.2.jar:git-Paper-307]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1173) ~[paper-1.19.2.jar:git-Paper-307]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:305) ~[paper-1.19.2.jar:git-Paper-307]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]

@EventHandler
    public void onBeaconDeactivate(BeaconDeactivatedEvent event) {
        Main.log("deactivated beacon: " + event);
        Beacon beacon = event.getBeacon();
        if (beacon == null) {
            Block block = event.getBlock();
            if (block.getType().equals(Material.BEACON)) {
                beacon = (Beacon) block.getState();
         ....
    }

Created issue manually because templates suck for this; but, this event should probably be improved so that it's not firing during chunk unload

[Lulu13022002]

There a little bit more of issue (depend if it's intended or not) but
The BeaconDeactivatedEvent is called when the beacon is destroyed even if not first activated
and the events ignore the obstruction of the beam

[Togira123]

Maybe the event could fire when it is destroyed, but contain an additional boolean field indicating whether the beacon was active before

[KillerCreeper112]

An "isActive()" function on the Beacon block state could be nice.

[dbechrd]

I need to be able to differentiate between the chunk unloading and the beacon actually being deactivated (e.g. beacon block broken, beacon beam impeded by a solid block, or pyramid size changed). How do I can do this reliably?

I really wish there were a BeaconEffectRangeChanged event that only got called when one of the things I mentioned above changed (as opposed to load/unload of chunks).