Skip to content

Commit 812c25f

Browse files
Roger Lamcwetherill-ps
andauthored
chore(tests): add integration tests for deployments command (#374)
Co-authored-by: Chris Wetherill <[email protected]>
1 parent a00fabc commit 812c25f

File tree

8 files changed

+322
-63
lines changed

8 files changed

+322
-63
lines changed

gradient/api_sdk/repositories/gradient_deployments.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
def create_deployment(name, project_id, spec, cluster_id=None, api_key=None):
66
client = graphql_client(api_key)
77
query = gql(
8-
"""
8+
"""
99
mutation createDeployment($input: CreateDeploymentInput!) {
1010
createDeployment(input: $input) {
1111
deployment {
@@ -29,7 +29,7 @@ def create_deployment(name, project_id, spec, cluster_id=None, api_key=None):
2929
def update_deployment(id, name=None, project_id=None, spec=None, cluster_id=None, api_key=None):
3030
client = graphql_client(api_key)
3131
query = gql(
32-
"""
32+
"""
3333
mutation updateDeployment($input: UpdateDeploymentInput!) {
3434
updateDeployment(input: $input) {
3535
deployment {
@@ -53,15 +53,15 @@ def update_deployment(id, name=None, project_id=None, spec=None, cluster_id=None
5353
input["spec"] = spec
5454

5555
params = {
56-
"input": input
56+
"input": input
5757
}
5858
return client.execute(query, variable_values=params)['updateDeployment']['deployment']
5959

6060

6161
def get_deployment(id, first=100, api_key=None):
6262
client = graphql_client(api_key)
6363
query = gql(
64-
"""
64+
"""
6565
query getDeployment($id: UUID!, $first: Int!) {
6666
deployment(id: $id) {
6767
id
@@ -133,7 +133,7 @@ def get_deployment(id, first=100, api_key=None):
133133
def list_deployments(first=100, api_key=None):
134134
client = graphql_client(api_key)
135135
query = gql(
136-
"""
136+
"""
137137
query getDeployments($first: Int!) {
138138
deployments(first: $first) {
139139
nodes {
@@ -187,7 +187,7 @@ def list_deployments(first=100, api_key=None):
187187
def delete_deployment(id, api_key=None):
188188
client = graphql_client(api_key)
189189
query = gql(
190-
"""
190+
"""
191191
mutation deleteDeployment($input: DeleteDeploymentInput!) {
192192
deleteDeployment(input: $input) {
193193
deployment {

gradient/cli/__init__.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,11 @@
1818
import gradient.cli.tensorboards
1919
import gradient.cli.workflows
2020
from gradient.api_sdk.config import config
21-
22-
2321
if config.USE_LEGACY_DEPLOYMENTS:
2422
import gradient.cli.deployments
2523
else:
2624
import gradient.cli.gradient_deployments
2725

28-
2926
def show(self, file=None):
3027
if file is None:
3128
file = get_text_stderr()

gradient/cli/cli.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,6 @@ def cli():
3131
pass
3232

3333

34-
# TODO: delete experiment - not implemented in the api
35-
# TODO: modify experiment - not implemented in the api
36-
# TODO: create experiment template?? What is the difference between experiment and experiment template?
37-
38-
3934
@cli.command("version", help="Show the version and exit")
4035
def get_version():
4136
command = login_commands.ShowVersionCommand()

gradient/cli/gradient_deployments.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
from gql import gql
77
from gql.transport.exceptions import TransportQueryError
88

9-
from gradient.api_sdk import create_deployment, list_deployments, delete_deployment, get_deployment, update_deployment
9+
from gradient.api_sdk.repositories import gradient_deployments
1010
from gradient.cli import common
1111
from gradient.cli.cli import cli
12-
from gradient.cli.common import api_key_option, ClickGroup
12+
from gradient.cli.common import api_key_option, ClickGroup
1313
from gradient.commands.helpers import print_table, formatted_graphql
1414
from gradient.exceptions import ApplicationError
1515

@@ -52,7 +52,6 @@ def deployments():
5252
help="Cluster ID",
5353
cls=common.GradientOption,
5454
)
55-
5655
@click.option(
5756
"--spec",
5857
"spec_path",
@@ -70,7 +69,7 @@ def create_deployment_command(ctx, api_key, name, project_id, cluster_id, spec_p
7069
return
7170

7271
try:
73-
deployment = create_deployment(name, project_id, spec, cluster_id, api_key=api_key)
72+
deployment = gradient_deployments.create_deployment(name, project_id, spec, cluster_id, api_key=api_key)
7473
print(f'Created deployment: {deployment["id"]}')
7574
except TransportQueryError as error:
7675
logger.error(error.errors[0]['message'])
@@ -126,20 +125,21 @@ def update_deployment_command(ctx, api_key, id, name, project_id, spec_path, clu
126125
return
127126

128127
try:
129-
deployment = update_deployment(id, name, project_id, spec, cluster_id, api_key=api_key)
128+
deployment = gradient_deployments.update_deployment(id, name, project_id, spec, cluster_id, api_key=api_key)
130129
print(f'Updated deployment: {deployment["id"]}')
131130
except TransportQueryError as error:
132131
logger.error(error.errors[0]['message'])
133132
except Exception as error:
134133
print(error)
135134
logger.error(f'There was an error, please try again')
136135

136+
137137
@deployments.command("list", help="List deployments")
138138
@api_key_option
139139
@click.pass_context
140140
def list_deployments_command(ctx, api_key):
141141
try:
142-
deployments = list_deployments(api_key=api_key)
142+
deployments = gradient_deployments.list_deployments(api_key=api_key)
143143
if len(deployments) == 0:
144144
print('No deployments found')
145145
return
@@ -167,11 +167,12 @@ def list_deployments_command(ctx, api_key):
167167
@click.pass_context
168168
def get_deployment_command(ctx, api_key, id):
169169
try:
170-
deployment = get_deployment(id, api_key=api_key)
170+
deployment = gradient_deployments.get_deployment(id, api_key=api_key)
171171
if deployment['deployment'] is None:
172172
print('Deployment not found')
173173
else:
174-
print(json.dumps(formatted_graphql(deployment['deployment']), indent=4))
174+
print(json.dumps(formatted_graphql(
175+
deployment['deployment']), indent=4))
175176
except TransportQueryError as error:
176177
logger.error(error.errors[0]['message'])
177178
except Exception as error:
@@ -191,8 +192,7 @@ def get_deployment_command(ctx, api_key, id):
191192
@click.pass_context
192193
def delete_deployment_command(ctx, api_key, id):
193194
try:
194-
deployment = delete_deployment(id, api_key=api_key)
195-
195+
deployment = gradient_deployments.delete_deployment(id, api_key=api_key)
196196
if deployment is None:
197197
print('Deployment not found')
198198
else:

0 commit comments

Comments
 (0)