Skip to content

Commit c165974

Browse files
fix(notebooks): remove --name from gradient notebooks start command (#362)
Tested against psdev, created a notebook in the UI, stopped it, ran ```bash python3 -m gradient notebooks start \ --clusterId <cluster ID> \ --machineType psdev-worker --notebookId <notebook ID> ``` and saw the notebook successfully restart. Verified that `--name` was no longer a valid CLI param for the command with ```bash python3 -m gradient notebooks start --help ```
1 parent 3a56306 commit c165974

File tree

3 files changed

+0
-10
lines changed

3 files changed

+0
-10
lines changed

gradient/api_sdk/clients/notebook_client.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ def start(
8787
id,
8888
machine_type,
8989
cluster_id=None,
90-
name=None,
9190
shutdown_timeout=None,
9291
is_preemptible=None,
9392
tags=None,
@@ -108,7 +107,6 @@ def start(
108107
notebook_id=id,
109108
machine_type=machine_type,
110109
cluster_id=cluster_id,
111-
notebook_name=name,
112110
shutdown_timeout=shutdown_timeout,
113111
is_preemptible=is_preemptible,
114112
)

gradient/api_sdk/models/notebook.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,5 +72,4 @@ class NotebookStart(object):
7272
cluster_id = attr.ib(type=str, default=None)
7373
shutdown_timeout = attr.ib(type=int, default=None)
7474
is_preemptible = attr.ib(type=bool, default=None)
75-
notebook_name = attr.ib(type=str, default=None)
7675

gradient/cli/notebooks.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -190,13 +190,6 @@ def create_notebook(api_key, options_file, **notebook):
190190
help="Cluster ID",
191191
cls=common.GradientOption,
192192
)
193-
@click.option(
194-
"--name",
195-
"name",
196-
type=str,
197-
help="Notebook name",
198-
cls=common.GradientOption,
199-
)
200193
@click.option(
201194
"--shutdownTimeout",
202195
"shutdown_timeout",

0 commit comments

Comments
 (0)