Remove (almost) unused var/item_color from /obj/item (#30453)

* it's black and white

* Update soft_caps.dm

* bruh

* bruh

* tweaks

* comment

* Update abduction_gear.dm

* Update paradise.dme

* Update paradise.dme

* Update paradise.dme

Author: kyunkyunkyun

code/game/gamemodes/miniantags/abduction/abduction_gear.dm

@@ -63,7 +63,6 @@ CONTENTS:
 	desc = "A highly breathable, alien uniform designed for optimal abduction and dissection."
 	icon_state = "abductor"
 	inhand_icon_state = "bl_suit"
-	item_color = "abductor"
 	has_sensor = FALSE
 
 	sprite_sheets = list(

code/game/machinery/computer/HolodeckControl.dm

@@ -354,48 +354,47 @@
 	icon = 'icons/obj/weapons/energy_melee.dmi'
 	lefthand_file = 'icons/mob/inhands/weapons_lefthand.dmi'
 	righthand_file = 'icons/mob/inhands/weapons_righthand.dmi'
-	icon_state = "sword0"
+	icon_state = "sword"
 	hitsound = "swing_hit"
 	force = 3.0
 	throw_speed = 1
 	throw_range = 5
 	w_class = WEIGHT_CLASS_SMALL
 	armor_penetration_percentage = 50
 	var/active = FALSE
+	/// Color of this e-sword. You can see supported colors in icon file
+	var/sword_color
 
 /obj/item/holo/esword/Initialize(mapload)
 	. = ..()
+	if(!sword_color)
+		sword_color = pick("red", "blue", "green", "purple")
 	AddComponent(/datum/component/parry, _stamina_constant = 2, _stamina_coefficient = 0.5, _parryable_attack_types = NON_PROJECTILE_ATTACKS)
 
-/obj/item/holo/esword/green/New()
-	..()
-	item_color = "green"
+/obj/item/holo/esword/update_icon_state()
+	icon_state = "[initial(icon_state)][active ? sword_color : ""]"
 
-/obj/item/holo/esword/red/New()
-	..()
-	item_color = "red"
+/obj/item/holo/esword/green
+	sword_color = "green"
+
+/obj/item/holo/esword/red
+	sword_color = "red"
 
 /obj/item/holo/esword/hit_reaction(mob/living/carbon/human/owner, atom/movable/hitby, attack_text = "the attack", final_block_chance = 0, damage = 0, attack_type = MELEE_ATTACK)
 	if(active)
 		return ..()
 	return 0
 
-/obj/item/holo/esword/New()
-	..()
-	item_color = pick("red","blue","green","purple")
-
 /obj/item/holo/esword/attack_self__legacy__attackchain(mob/living/user as mob)
 	active = !active
 	if(active)
 		force = 30
-		icon_state = "sword[item_color]"
 		hitsound = "sound/weapons/blade1.ogg"
 		w_class = WEIGHT_CLASS_BULKY
 		playsound(user, 'sound/weapons/saberon.ogg', 20, 1)
 		to_chat(user, "<span class='notice'>[src] is now active.</span>")
 	else
 		force = 3
-		icon_state = "sword0"
 		hitsound = "swing_hit"
 		w_class = WEIGHT_CLASS_SMALL
 		playsound(user, 'sound/weapons/saberoff.ogg', 20, 1)
@@ -405,7 +404,7 @@
 		H.update_inv_l_hand()
 		H.update_inv_r_hand()
 	add_fingerprint(user)
-	return
+	update_icon(UPDATE_ICON_STATE)
 
 /obj/machinery/readybutton
 	name = "Ready Declaration Device"

code/game/objects/items.dm

@@ -99,7 +99,6 @@ GLOBAL_DATUM_INIT(welding_sparks, /mutable_appearance, mutable_appearance('icons
 	var/dyeing_key
 	/// If this item is put into a washing machine to be dyed, can objects of this type be dyed into a different color/icon?
 	var/dyeable = FALSE
-	var/item_color
 	/// What bodyflags does this item cover? See setup.dm for appropriate bit flags
 	var/body_parts_covered = 0
 	/// For leaking gas from turf to mask and vice-versa.

code/game/objects/items/bio_chips/bio_chip.dm

@@ -10,7 +10,6 @@
 	icon_state = "generic" //Shows up as a auto surgeon, used as a placeholder when a implant doesn't have a sprite
 	origin_tech = "materials=2;biotech=3;programming=2"
 	actions_types = list(/datum/action/item_action/hands_free/activate)
-	item_color = "black"
 	flags = DROPDEL  // By default, don't let implants be harvestable.
 
 	///which implant overlay should be used for implant cases. This should point to a state in bio_chips.dmi

code/game/objects/items/bio_chips/bio_chip_shock.dm

@@ -2,7 +2,6 @@
 	name = "power bio-chip"
 	desc = "A shockingly effective bio-chip for stunning or killing all those in your way. Do it."
 	icon_state = "lighting_bolt"
-	item_color = "r"
 	origin_tech = "combat=5;magnets=3;biotech=4;syndicate=2"
 	implant_data = /datum/implant_fluff/shock
 	implant_state = "implant-syndicate"

code/game/objects/items/bio_chips/bio_chip_storage.dm

@@ -13,7 +13,6 @@
 	desc = "Stores up to two big items in a bluespace pocket."
 	icon_state = "storage"
 	origin_tech = "materials=2;magnets=4;bluespace=5;syndicate=4"
-	item_color = "r"
 	implant_data = /datum/implant_fluff/storage
 	implant_state = "implant-syndicate"
 

code/game/objects/items/collar.dm

@@ -2,7 +2,6 @@
 	name = "pet collar"
 	desc = "The latest fashion accessory for your favorite pets!"
 	icon_state = "petcollar"
-	item_color = "petcollar"
 	var/tagname = null
 	var/original_name
 	var/original_real_name

code/game/objects/items/dyeing.dm

@@ -30,7 +30,6 @@
 	worn_icon_state = initial(target_obj.worn_icon_state)
 	inhand_icon_state = initial(target_obj.inhand_icon_state)
 	sprite_sheets = target_obj.sprite_sheets
-	item_color = target_obj.item_color
 	desc = target_obj.desc
 	base_icon_state = target_obj.base_icon_state
 

code/game/objects/items/toys.dm

@@ -171,7 +171,7 @@
 	name = "toy sword"
 	desc = "A cheap, plastic replica of an energy sword. Realistic sounds! Ages 8 and up."
 	icon = 'icons/obj/weapons/energy_melee.dmi'
-	icon_state = "sword0"
+	icon_state = "sword"
 	lefthand_file = 'icons/mob/inhands/weapons_lefthand.dmi'
 	righthand_file = 'icons/mob/inhands/weapons_righthand.dmi'
 	var/active = FALSE
@@ -190,7 +190,7 @@
 	else
 		to_chat(user, "<span class='notice'>You push the plastic blade back down into the handle.</span>")
 		playsound(user, 'sound/weapons/saberoff.ogg', 20, 1)
-		icon_state = "sword0"
+		icon_state = "sword"
 		w_class = WEIGHT_CLASS_SMALL
 
 	if(ishuman(user))
@@ -442,15 +442,17 @@
 	icon_state = "therapyred"
 	inhand_icon_state = "egg4"
 	w_class = WEIGHT_CLASS_TINY
-	var/cooldown = 0
 	resistance_flags = FLAMMABLE
+	var/cooldown = 0
+	/// Color of the doll. Affects appearance, make sure there is appropriate icon_state in icon file
+	var/doll_color
 
-/obj/item/toy/therapy/New()
-	..()
-	if(item_color)
-		name = "[item_color] therapy doll"
-		desc += " This one is [item_color]."
-		icon_state = "therapy[item_color]"
+/obj/item/toy/therapy/Initialize(mapload)
+	. = ..()
+	if(doll_color)
+		name = "[doll_color] therapy doll"
+		desc += " This one is [doll_color]."
+		icon_state = "therapy[doll_color]"
 
 /obj/item/toy/therapy/activate_self(mob/user)
 	if(..() || !(cooldown < world.time - 8))
@@ -460,26 +462,26 @@
 	cooldown = world.time
 
 /obj/item/toy/therapy/red
-	item_color = "red"
+	doll_color = "red"
 
 /obj/item/toy/therapy/purple
 	inhand_icon_state = "egg1" // It's the magenta egg in items_left/righthand
-	item_color = "purple"
+	doll_color = "purple"
 
 /obj/item/toy/therapy/blue
 	inhand_icon_state = "egg2" // It's the blue egg in items_left/righthand
-	item_color = "blue"
+	doll_color = "blue"
 
 /obj/item/toy/therapy/yellow
 	inhand_icon_state = "egg5" // It's the yellow egg in items_left/righthand
-	item_color = "yellow"
+	doll_color = "yellow"
 
 /obj/item/toy/therapy/orange
-	item_color = "orange"
+	doll_color = "orange"
 
 /obj/item/toy/therapy/green
 	inhand_icon_state = "egg3" // It's the green egg in items_left/righthand
-	item_color = "green"
+	doll_color = "green"
 
 /*
  * Fake meteor

code/game/objects/items/weapons/bio_chips/bio_chip_freedom.dm

@@ -2,7 +2,6 @@
 	name = "freedom bio-chip"
 	desc = "Use this to escape from those evil Red Shirts."
 	icon_state = "freedom"
-	item_color = "r"
 	origin_tech = "combat=5;magnets=3;biotech=4;syndicate=2"
 	uses = 4
 	implant_data = /datum/implant_fluff/freedom