internals: unbroadening base exception classes

NotImplementedError : runtime_error
ValueError : invalid_argument

Author: torbjoernk

include/pfasst/interfaces.hpp

@@ -5,8 +5,8 @@
 #ifndef _PFASST_INTERFACES_HPP_
 #define _PFASST_INTERFACES_HPP_
 
-#include <exception>
 #include <memory>
+#include <stdexcept>
 #include <string>
 using namespace std;
 
@@ -23,12 +23,20 @@ namespace pfasst
    * that may not be necessary for all others.
    */
   class NotImplementedYet
-    : public exception
+    : public runtime_error
   {
     protected:
       string msg;
+
     public:
-      NotImplementedYet(const string& msg);
+      /**
+       * @param[in] msg component or algorithm the throwing function is required for
+       */
+      explicit NotImplementedYet(const string& msg);
+
+      /**
+       * message string is prepended by the string `Not implemented/supported yet, required for: `
+       */
       virtual const char* what() const throw();
   };
 
@@ -39,12 +47,17 @@ namespace pfasst
    * Thrown when a PFASST routine is passed an invalid value.
    */
   class ValueError
-    : public exception
+    : public invalid_argument
   {
     protected:
       string msg;
+
     public:
-      ValueError(const string& msg);
+      explicit ValueError(const string& msg);
+
+      /**
+       * message string is prepended by the string `ValueError: `
+       */
       virtual const char* what() const throw();
   };
 
@@ -89,7 +102,7 @@ namespace pfasst
 
   /**
    * abstract SDC sweeper.
-   * @tparam time time precision
+   * @tparam time time precision;
    *     defaults to pfasst::time_precision
    */
   template<typename time = time_precision>
@@ -195,7 +208,7 @@ namespace pfasst
 
   /**
    * abstract time/space transfer (restrict/interpolate) class.
-   * @tparam time time precision
+   * @tparam time time precision;
    *     defaults to pfasst::time_precision
    */
   template<typename time = time_precision>

include/pfasst/interfaces_impl.hpp

@@ -11,7 +11,7 @@ using namespace std;
 namespace pfasst
 {
   NotImplementedYet::NotImplementedYet(const string& msg)
-    : msg(msg)
+    : runtime_error(msg)
   {}
 
   const char* NotImplementedYet::what() const throw()
@@ -21,7 +21,7 @@ namespace pfasst
 
 
   ValueError::ValueError(const string& msg)
-    : msg(msg)
+    : invalid_argument(msg)
   {}
 
   const char* ValueError::what() const throw()