Skip to content

Commit 38bbc69

Browse files
committed
cmake: remove dead code
did I mention, that this dirty hack and fiddling with internal properties has been obsolete and removed? 👍
1 parent bea531e commit 38bbc69

File tree

1 file changed

+5
-24
lines changed

1 file changed

+5
-24
lines changed

3rdparty/CMakeLists.txt

Lines changed: 5 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,8 @@ if(NOT EIGEN3_FOUND)
6666
)
6767

6868
# Specify include dir
69-
set(Eigen3_INCLUDE_PATH "${Eigen3_SOURCE_DIR}")# CACHE PATH "" FORCE)
70-
71-
# mark_as_advanced(Eigen3_INCLUDE_PATH)
69+
set(Eigen3_INCLUDE_PATH "${Eigen3_SOURCE_DIR}")
7270
set(Eigen3_FOUND TRUE)
73-
# set_property(GLOBAL APPEND PROPERTY PACKAGES_FOUND "Eigen3")
74-
# get_property(packages_not_found GLOBAL PROPERTY PACKAGES_NOT_FOUND)
75-
# list(REMOVE_ITEM packages_not_found "Eigen3")
76-
# set_property(GLOBAL PROPERTY PACKAGES_NOT_FOUND ${packages_not_found})
77-
# unset(packages_not_found)
7871

7972
list(APPEND pfasst_DEPENDEND_TARGETS Eigen3)
8073

@@ -123,15 +116,9 @@ if(NOT EASYLOGGING++_FOUND)
123116
LOG_BUILD OFF
124117
)
125118

126-
# Specify include dir and hack on CMake internals to overwrite internal not-found flag
127-
set(Easylogging++_INCLUDE_PATH "${Easylogging++_SOURCE_DIR}")# CACHE PATH "" FORCE)
128-
# mark_as_advanced(Easyloggingpp_INCLUDE_PATH)
119+
# Specify include dir
120+
set(Easylogging++_INCLUDE_PATH "${Easylogging++_SOURCE_DIR}")
129121
set(EASYLOGGING++_FOUND TRUE)
130-
# set_property(GLOBAL APPEND PROPERTY PACKAGES_FOUND "Easylogging++")
131-
# get_property(packages_not_found GLOBAL PROPERTY PACKAGES_NOT_FOUND)
132-
# list(REMOVE_ITEM packages_not_found "Easylogging++")
133-
# set_property(GLOBAL PROPERTY PACKAGES_NOT_FOUND ${packages_not_found})
134-
# unset(packages_not_found)
135122

136123
list(APPEND pfasst_DEPENDEND_TARGETS Easylogging++)
137124

@@ -181,16 +168,10 @@ if(pfasst_BUILD_EXAMPLES)
181168
LOG_BUILD ON
182169
)
183170
# Specify include dir
184-
set(FFTW_INCLUDE_PATH ${fftw3_INSTALL_DIR}/include)# CACHE PATH "" FORCE)
185-
set(FFTW_LIBRARIES ${fftw3_INSTALL_DIR}/lib/libfftw3.a)# CACHE FILEPATH "" FORCE)
171+
set(FFTW_INCLUDE_PATH ${fftw3_INSTALL_DIR}/include)
172+
set(FFTW_LIBRARIES ${fftw3_INSTALL_DIR}/lib/libfftw3.a)
186173

187-
# mark_as_advanced(FFTW_INCLUDE_PATH FFTW_LIBRARIES)
188174
set(FFTW_FOUND TRUE)
189-
# set_property(GLOBAL APPEND PROPERTY PACKAGES_FOUND "FFTW")
190-
# get_property(packages_not_found GLOBAL PROPERTY PACKAGES_NOT_FOUND)
191-
# list(REMOVE_ITEM packages_not_found "FFTW")
192-
# set_property(GLOBAL PROPERTY PACKAGES_NOT_FOUND ${packages_not_found})
193-
# unset(packages_not_found)
194175

195176
list(APPEND pfasst_DEPENDEND_LIBS FFTW)
196177

0 commit comments

Comments
 (0)