flake8-bugbear

Author: pancetta

.flake8

@@ -1,6 +1,6 @@
 [flake8]
 max-line-length = 120
-select = C4
+select = C,E,F,W,B,B9
 ignore = E741, E402, W504, W605, C408
 per-file-ignores =
     pySDC/tutorial/step_6/C_MPI_parallelization.py:F401,

pySDC/core/Step.py

@@ -168,7 +168,7 @@ def __dict_to_list(in_dict):
         """
 
         max_val = 1
-        for k, v in in_dict.items():
+        for _, v in in_dict.items():
             if type(v) is list:
                 max_val = max(max_val, len(v))
             else:

pySDC/helpers/stats_helper.py

@@ -62,7 +62,7 @@ def get_list_of_types(stats):
     """
 
     type_list = []
-    for k, v in stats.items():
+    for k, _ in stats.items():
         if k.type not in type_list:
             type_list.append(k.type)
     return type_list

pySDC/helpers/visualization_tools.py

@@ -28,17 +28,17 @@ def show_residual_across_simulation(stats, fname='residuals.png'):
     minres = 0
     maxres = -99
     for k, v in extract_stats.items():
-        maxprocs = max(maxprocs, getattr(k, 'process'))
-        maxiter = max(maxiter, getattr(k, 'iter'))
+        maxprocs = max(maxprocs, k.process)
+        maxiter = max(maxiter, k.iter)
         minres = min(minres, np.log10(v))
         maxres = max(maxres, np.log10(v))
 
     # grep residuals and put into array
     residual = np.zeros((maxiter, maxprocs + 1))
     residual[:] = -99
     for k, v in extract_stats.items():
-        step = getattr(k, 'process')
-        iter = getattr(k, 'iter')
+        step = k.process
+        iter = k.iter
         if iter is not -1:
             residual[iter - 1, step] = np.log10(v)
 

pySDC/implementations/controller_classes/controller_MPI.py

@@ -609,7 +609,7 @@ def it_down():
 
                 nsweeps = self.S.levels[l].params.nsweeps
 
-                for k in range(nsweeps):
+                for _ in range(nsweeps):
 
                     self.hooks.pre_comm(step=self.S, level_number=l)
 

pySDC/implementations/controller_classes/controller_nonMPI.py

@@ -35,12 +35,12 @@ def __init__(self, num_procs, controller_params, description):
 
         # try to initialize via dill.copy (much faster for many time-steps)
         try:
-            for p in range(num_procs - 1):
+            for _ in range(num_procs - 1):
                 self.MS.append(dill.copy(self.MS[0]))
         # if this fails (e.g. due to un-picklable data in the steps), initialize seperately
         except dill.PicklingError and TypeError:
             self.logger.warning('Need to initialize steps separately due to pickling error')
-            for p in range(num_procs - 1):
+            for _ in range(num_procs - 1):
                 self.MS.append(stepclass.step(description))
 
         if self.params.dump_setup:
@@ -548,7 +548,7 @@ def it_down(local_MS_running):
 
                 # sweep on middle levels (not on finest, not on coarsest, though)
 
-                for k in range(self.nsweeps[l]):
+                for _ in range(self.nsweeps[l]):
 
                     for S in local_MS_running:
 

pySDC/implementations/datatype_classes/mesh.py

@@ -65,7 +65,7 @@ def __array_ufunc__(self, ufunc, method, *inputs, out=None, **kwargs):
         """
         args = []
         comm = None
-        for i, input_ in enumerate(inputs):
+        for _, input_ in enumerate(inputs):
             if isinstance(input_, mesh):
                 args.append(input_.view(np.ndarray))
                 comm = input_.comm

pySDC/implementations/problem_classes/GrayScott_1D_FEniCS_implicit.py

@@ -56,7 +56,7 @@ def Boundary(x, on_boundary):
 
         # set mesh and refinement (for multilevel)
         mesh = df.IntervalMesh(problem_params['c_nvars'], 0, 100)
-        for i in range(problem_params['refinements']):
+        for _ in range(problem_params['refinements']):
             mesh = df.refine(mesh)
 
         # define function space for future reference

pySDC/implementations/problem_classes/HeatEquation_1D_FEniCS_matrix_forced.py

@@ -54,7 +54,7 @@ def __init__(self, problem_params, dtype_u=fenics_mesh, dtype_f=rhs_fenics_mesh)
 
         # set mesh and refinement (for multilevel)
         mesh = df.UnitIntervalMesh(problem_params['c_nvars'])
-        for i in range(problem_params['refinements']):
+        for _ in range(problem_params['refinements']):
             mesh = df.refine(mesh)
 
         # define function space for future reference

pySDC/implementations/problem_classes/HeatEquation_1D_FEniCS_weak_forced.py

@@ -55,7 +55,7 @@ def Boundary(x, on_boundary):
 
         # set mesh and refinement (for multilevel)
         mesh = df.UnitIntervalMesh(problem_params['c_nvars'])
-        for i in range(problem_params['refinements']):
+        for _ in range(problem_params['refinements']):
             mesh = df.refine(mesh)
 
         # define function space for future reference
@@ -231,7 +231,7 @@ def Boundary(x, on_boundary):
 
         # set mesh and refinement (for multilevel)
         mesh = df.UnitIntervalMesh(problem_params['c_nvars'])
-        for i in range(problem_params['refinements']):
+        for _ in range(problem_params['refinements']):
             mesh = df.refine(mesh)
 
         # define function space for future reference