Skip to content

Commit 964556d

Browse files
committed
TL: ghnghng again ...
1 parent bf3ba5c commit 964556d

File tree

2 files changed

+13
-15
lines changed

2 files changed

+13
-15
lines changed

pySDC/playgrounds/dedalus/problems/rbc.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -230,25 +230,25 @@ def runSimulation(cls, runDir, tEnd, baseDt, tBeg=0, logEvery=100,
230230
cls.log(f"RBC simulation in {runDir}")
231231

232232
if timeScheme == "RK443":
233-
timeStepper = d3.RK443
233+
TimeStepper = d3.RK443
234234
elif timeScheme == "RK111":
235-
timeStepper = d3.RK111
235+
TimeStepper = d3.RK111
236236
elif timeScheme == "RK222":
237-
timeStepper = d3.RK222
237+
TimeStepper = d3.RK222
238238
elif timeScheme == "SDC":
239-
timeStepper = SDCIMEX
239+
TimeStepper = SDCIMEX
240240
else:
241-
raise NotImplementedError(f"{timeStepper=}")
242-
cls.log(f" -- selected time-stepper : {timeStepper}")
241+
raise NotImplementedError(f"{timeScheme=}")
242+
cls.log(f" -- selected time-stepper : {TimeStepper}")
243243

244244
if timeParallel:
245245
assert timeScheme == "SDC", "need timeScheme=SDC for timeParallel"
246246
_, sComm, _ = SDCIMEX_MPI.initSpaceTimeComms(groupTime=groupTimeProcs)
247247
pParams.update(sComm=sComm)
248248
if timeParallel == "MPI":
249-
timeScheme = SDCIMEX_MPI
249+
TimeStepper = SDCIMEX_MPI
250250
elif timeParallel == "MPI2":
251-
timeScheme = SDCIMEX_MPI2
251+
TimeStepper = SDCIMEX_MPI2
252252
else:
253253
raise NotImplementedError(f"{timeParallel=}")
254254
cls.log(f" -- activated PinT for SDC : {timeParallel}")
@@ -270,7 +270,7 @@ def runSimulation(cls, runDir, tEnd, baseDt, tBeg=0, logEvery=100,
270270

271271
# Solver
272272
cls.log(" -- building dedalus solver ...")
273-
solver = p.problem.build_solver(timeStepper)
273+
solver = p.problem.build_solver(TimeStepper)
274274
solver.sim_time = tBeg
275275
solver.stop_sim_time = tEnd
276276
cls.log(" -- done !")

pySDC/playgrounds/dedalus/scripts/plotScaling.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,21 @@
1111

1212
folder = "_benchJusuf"
1313

14-
methods = ["RK443", "SDC"]
15-
res = 2
14+
methods = ["RK443", "SDC", "SDC-MPI"]
15+
R = 2
1616

1717
useNSpS = False
1818
nSpS = {
1919
"RK443": 23,
2020
"SDC": 17,
21+
"SDC-MPI": 17,
2122
}
2223

2324
results = {}
2425

2526
for scheme in methods:
2627

27-
files = glob.glob(f"{folder}/R{res}_{scheme}*.json")
28+
files = glob.glob(f"{folder}/R{R}_{scheme}_*.json")
2829

2930
results[scheme] = []
3031

@@ -39,9 +40,6 @@
3940
nP = infos["MPI_SIZE"]
4041
if useNSpS:
4142
tSim *= nSpS[scheme]
42-
if scheme == "SDC" and useNSpS:
43-
tSim /= 3
44-
nP *= 4
4543
results[scheme].append([nP, tSim])
4644

4745
results[scheme].sort(key=lambda p: p[0])

0 commit comments

Comments
 (0)