test: equals and hashcode

Author: ParanoidUser

kata/6-kyu/fractions-class/test/SolutionTest.java

@@ -1,5 +1,4 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 
 import org.junit.jupiter.api.Test;
@@ -37,14 +36,13 @@ void string_representation() {
 
   @Test
   void equals_fractions() {
-    assertEquals(new Fraction(1, 2), new Fraction(2, 4));
-    assertEquals(new Fraction(2, 2), new Fraction(3, 3));
-    assertNotEquals(new Fraction(1, 2), new Fraction(2, 1));
-    assertNotEquals(new Fraction(1, 2), new Object());
-
     var f = new Fraction(1, 2);
+    assertEquals(f, new Fraction(1, 2));
+    assertEquals(f, new Fraction(2, 4));
     assertEquals(f, f);
-    assertFalse(f.equals(null));
+    assertNotEquals(f, new Fraction(2, 1));
+    assertNotEquals(f, new Object());
+    assertNotEquals(null, f);
   }
 
   @Test

kata/6-kyu/hex-class/test/SampleTests.java

@@ -1,5 +1,4 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 
 import org.junit.jupiter.api.Test;
@@ -11,18 +10,18 @@ void sample() {
     assertEquals("0xFF", ff.toString());
     assertEquals(256, ff.valueOf() + 1);
     assertEquals("0xFF", ff.toJSON());
-    assertEquals(ff, new Hex(255));
     assertEquals("0xFE", ff.minus(1).toString());
     assertEquals("0x0", ff.minus(ff).toString());
     assertEquals("0xF", new Hex(10).plus(5).toString());
     assertEquals("0x1FE", ff.plus(ff).toString());
     assertEquals(32, Hex.parse("0x20"));
     assertEquals(512, Hex.parse("200"));
-    assertNotEquals(new Hex(1), new Hex(2));
-    assertNotEquals(new Hex(1), new Object());
-    assertEquals(255, new Hex(255).hashCode());
 
     assertEquals(ff, ff);
-    assertFalse(ff.equals(null));
+    assertEquals(ff, new Hex(255));
+    assertNotEquals(ff, new Hex(2));
+    assertNotEquals(ff, new Object());
+    assertNotEquals(null, ff);
+    assertEquals(255, ff.hashCode());
   }
 }

kata/6-kyu/parse-html-slash-css-colors/test/RGBTest.java

@@ -1,5 +1,4 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 
 import org.junit.jupiter.api.Test;
@@ -20,10 +19,10 @@ void equals_test() {
     assertEquals(new RGB(0,256,0), new RGB(0,256,0));
     var black = new RGB(0,0,0);
     assertEquals(black, black);
-    assertFalse(new RGB(0,0,0).equals(null));
-    assertNotEquals(new RGB(0,0,0), new Object());
-    assertNotEquals(new RGB(0,0,0), new RGB(1,0,0));
-    assertNotEquals(new RGB(0,0,0), new RGB(0,1,0));
-    assertNotEquals(new RGB(0,0,0), new RGB(0,0,1));
+    assertNotEquals(black, new Object());
+    assertNotEquals(black, new RGB(1,0,0));
+    assertNotEquals(black, new RGB(0,1,0));
+    assertNotEquals(black, new RGB(0,0,1));
+    assertNotEquals(null, black);
   }
 }

kata/6-kyu/the-difference-between-11-and-21-in-ping-pong/test/ScoreTest.java

@@ -1,5 +1,4 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 
 import org.junit.jupiter.api.Test;
@@ -11,13 +10,15 @@ void equalsTest() {
     assertEquals(score, score);
     assertEquals(score, new Score(1, 1));
     assertNotEquals(score, new Score(1, 2));
+    assertNotEquals(score, new Score(2, 1));
     assertNotEquals(score, new Object());
-    assertFalse(score.equals(null));
+    assertNotEquals(null, score);
   }
 
   @Test
   void hashCodeTest() {
-    assertEquals(3541, new Score(1, 1).hashCode());
+    assertEquals(3542, new Score(1, 2).hashCode());
+    assertEquals(3600, new Score(2, 1).hashCode());
   }
 
   @Test