Skip to content

Commit 98395a0

Browse files
committed
Remove setting of converters
1 parent e380c0a commit 98395a0

File tree

2 files changed

+1
-12
lines changed

2 files changed

+1
-12
lines changed

src/parcels/_core/fieldset.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import xarray as xr
1111
import xgcm
1212

13-
from parcels._core.converters import Geographic, GeographicPolar
1413
from parcels._core.field import Field, VectorField
1514
from parcels._core.utils import sgrid
1615
from parcels._core.utils.string import _assert_str_and_python_varname
@@ -384,11 +383,6 @@ def from_sgrid_conventions(
384383
fields[varname] = Field(varname, ds[varname], grid, XLinear)
385384

386385
fieldset = cls(list(fields.values()))
387-
if mesh == "spherical":
388-
if "U" in fieldset.fields:
389-
fieldset.U.units = GeographicPolar()
390-
if "V" in fieldset.fields:
391-
fieldset.V.units = Geographic()
392386
return fieldset
393387

394388

tests/test_advection.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -438,12 +438,7 @@ def test_nemo_curvilinear_fieldset():
438438
"kernel",
439439
[
440440
AdvectionRK4,
441-
pytest.param(
442-
AdvectionRK4_3D,
443-
marks=pytest.mark.xfail(
444-
reason="from_nemo had 'fieldset.V.units = GeographicPolar()', I'm not sure _why_ this code is needed to get this to pass. To be further investigated.",
445-
),
446-
),
441+
AdvectionRK4_3D,
447442
],
448443
)
449444
def test_nemo_3D_curvilinear_fieldset(kernel):

0 commit comments

Comments
 (0)