Review feedback

Author: VeckoTheGecko

parcels/xgrid.py

@@ -101,7 +101,7 @@ def __init__(self, grid: xgcm.Grid, mesh="flat"):
 
     @classmethod
     def from_dataset(cls, ds: xr.Dataset, mesh="flat", xgcm_kwargs=None):
-        """WARNING: unstable API, subject to change in future versions."""
+        """WARNING: unstable API, subject to change in future versions."""  # TODO v4: make private or remove warning on v4 release
         if xgcm_kwargs is None:
             xgcm_kwargs = {}
 

tests/utils.py

@@ -126,7 +126,7 @@ def assert_empty_folder(path: Path):
 
 
 def assert_valid_field_data(data: xr.DataArray, grid: XGrid):
-    assert len(data.shape) == 4, f"Field data should have 4 dimensions (time, depth, lat, lon), got {len(data.shape)}"
+    assert len(data.shape) == 4, f"Field data should have 4 dimensions (time, depth, lat, lon), got dims {data.dims}"
 
     for ax_expected, dim in zip(_FIELD_DATA_ORDERING, data.dims, strict=True):
         ax_actual = get_axis_from_dim_name(grid.xgcm_grid.axes, dim)