Skip to content

Commit e74d2ba

Browse files
committed
Review feedback
1 parent 6d1cf43 commit e74d2ba

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

src/parcels/_core/fieldset.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -380,8 +380,7 @@ def from_sgrid_conventions(
380380
for varname in set(ds.data_vars) - set(fields.keys()) - skip_vars:
381381
fields[varname] = Field(varname, ds[varname], grid, XLinear)
382382

383-
fieldset = cls(list(fields.values()))
384-
return fieldset
383+
return cls(list(fields.values()))
385384

386385

387386
class CalendarError(Exception): # TODO: Move to a parcels errors module

tests/test_advection.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -463,13 +463,7 @@ def test_nemo_curvilinear_fieldset():
463463
np.testing.assert_allclose(pset.lat, latp, atol=1e-1)
464464

465465

466-
@pytest.mark.parametrize(
467-
"kernel",
468-
[
469-
AdvectionRK4,
470-
AdvectionRK4_3D,
471-
],
472-
)
466+
@pytest.mark.parametrize("kernel", [AdvectionRK4, AdvectionRK4_3D])
473467
def test_nemo_3D_curvilinear_fieldset(kernel):
474468
data_folder = parcels.download_example_dataset("NemoNorthSeaORCA025-N006_data")
475469
U = xr.open_mfdataset(data_folder.glob("*U.nc"))

0 commit comments

Comments
 (0)