Skip to content

API Design: Specifying Unit conversion for fields #1943

@VeckoTheGecko

Description

@VeckoTheGecko

In v3 we used fieldtype and the mesh (flat or spherical) to determine the UnitConverter object that is associated with a field.

It would be good to reconsider how this is done in the overall v4 API (or, at least, in terms of naming). This will become clearer further in v4 development


Should we be concerned with the naming of

UWind.units = parcels.tools.converters.GeographicPolar()
VWind.units = parcels.tools.converters.Geographic()

? Previously it might have been easier to identify that VWind would be of field type V, whereas now its probably not as clear to the user that it needs a Geographic converter and not a GeographicPolar converter. Perhaps this would just be something to keep an eye on moving forward, that we can revisit the naming/how to specify these unit converters.

Originally posted by @VeckoTheGecko in #1942 (review)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Done

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions