diff --git a/CHANGELOG.md b/CHANGELOG.md index 817d8d6..c27daa5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,6 @@ +### v1.14.5 +- Update `property_v2.search` to fix pagination logic bug. + ### v1.14.4 - Internal code improvements. diff --git a/parcllabs/__version__.py b/parcllabs/__version__.py index 43fc4a2..0a028af 100644 --- a/parcllabs/__version__.py +++ b/parcllabs/__version__.py @@ -1 +1 @@ -VERSION = "1.14.4" +VERSION = "1.14.5" diff --git a/parcllabs/services/properties/property_v2.py b/parcllabs/services/properties/property_v2.py index 3741b21..336fcab 100644 --- a/parcllabs/services/properties/property_v2.py +++ b/parcllabs/services/properties/property_v2.py @@ -28,7 +28,7 @@ def _fetch_post(self, params: dict[str, Any], data: dict[str, Any]) -> list[dict if pagination: limit = pagination.get("limit") - if returned_count == limit: + if returned_count < limit: # if we got fewer results than requested, don't paginate return all_data # If we need to paginate, use concurrent requests diff --git a/tests/test_property_v2.py b/tests/test_property_v2.py index 7c70708..e51a4a6 100644 --- a/tests/test_property_v2.py +++ b/tests/test_property_v2.py @@ -252,9 +252,9 @@ def test_fetch_post_pagination(mock_post: Mock, property_v2_service: PropertyV2S result = property_v2_service._fetch_post(params={"limit": 1}, data={}) - assert len(result) == 1 + assert len(result) == 2 assert result[0]["data"][0]["parcl_id"] == 123 - assert mock_post.call_count == 1 + assert mock_post.call_count == 2 def test_as_pd_dataframe(property_v2_service: PropertyV2Service, mock_response: Mock) -> None: