Skip to content

Subtitles can be malformed #53

@kagikn

Description

@kagikn

The replaced subtitles for voice lines will be malformed when the text contains any characters whose values are more than 0xFF. You can reproduce the issue by playing the game in Japanese.
I’m sure it’s because of this part of code. I’ll create a PR for the issue soon.

std::string string = "";
for (char *str = data.m_aData + offset; *str; str += 2)
string.push_back (*str);
mTexts[hash] = std::string (string);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions