General: Fix file descriptor leak

* fclose's all files properly now. Should not cause errors after a
  long playing session.

Author: Parik27

src/colours/weather_Timecycle.hh

@@ -307,6 +307,8 @@ struct WeatherRandomizer_Tunables
                             m_Fields.pop_back ();
                     }
             }
+
+        fclose (f);
     }
 
     void

src/common/parser.hh

@@ -102,6 +102,8 @@ private:
                         m_Groups.back ().Weights.push_back (weight);
                     }
             }
+
+        fclose(file);
     }
 
 public:
@@ -183,6 +185,8 @@ private:
                 m_List.Values.push_back (model);
                 m_List.Weights.push_back (weight);
             }
+
+        fclose (file);
     }
 
 public:

src/debug/timecycle.cc

@@ -480,6 +480,7 @@ struct TimecycleRandomizerTunables
                             }
                     }
             }
+        fclose (file);
     }
 };
 

src/misc/ramps.cc

@@ -85,6 +85,8 @@ class RampRandomizer
                 info.Model  = rage::atStringHash (ModelName);
                 sm_RampInfos.push_back (info);
             }
+
+        fclose (f);
     }
 
     /*******************************************************/

src/misc/scaleform.cc

@@ -135,6 +135,7 @@ class ScaleformRandomizer
                 m_MissionFailInsults.back () += ' ';
             }
 
+        fclose (insultsFile);
         return;
     }
 

src/mission/missions_Data.hh

@@ -108,5 +108,7 @@ public:
                     Rainbomizer::Logger::LogMessage (
                         "Error reading Missions.txt line: %s", line);
             }
+
+        fclose (file);
     }
 };

src/peds/peds_Streaming.hh

@@ -81,6 +81,8 @@ class PedRandomizer_Streaming
                 line[strcspn (line, "\n")] = 0;
                 out.push_back (rage::atStringHash (line));
             }
+
+        fclose (f);
     }
 
     /*******************************************************/

src/sounds/voicelines.cc

@@ -410,6 +410,7 @@ class VoiceLineRandomizer
                                         rage::atPartialStringHash (context),
                                         subtitle});
             }
+        fclose (soundsFile);
         Rainbomizer::Logger::LogMessage ("Initialised %d voice lines",
                                          mSubtitles.size ());
     }

src/vehicles/traffic.cc

@@ -24,6 +24,7 @@ class TrafficRandomizer
             bool EnableBoats  = true;
 
             bool DisableBigVehicles = false;
+            bool DisableLoadingTraffic = false;
         } m_Config;
 
         return m_Config;
@@ -57,6 +58,7 @@ class TrafficRandomizer
                 aList.push_back (rage::atStringHash (line));
             }
 
+        fclose (f);
         return &aList;
     }
 
@@ -80,6 +82,9 @@ class TrafficRandomizer
     /*******************************************************/
     static uint32_t __fastcall RandomizeCarToLoad (CStreaming *inst)
     {
+        if (Config ().DisableLoadingTraffic)
+            return 65535;
+
         auto &vehicles = Rainbomizer::Common::GetVehicleHashes ();
         for (int i = 0; i < 16; i++)
             {
@@ -102,14 +107,8 @@ class TrafficRandomizer
     /*******************************************************/
     TrafficRandomizer ()
     {
-        if (!ConfigManager::ReadConfig (
-                "TrafficRandomizer",
-                std::pair ("EnablePlanes", &Config ().EnablePlanes),
-                std::pair ("EnableHelis", &Config ().EnableHelis),
-                std::pair ("EnableBoats", &Config ().EnableBoats),
-                std::pair ("DisableBigVehicles",
-                           &Config ().DisableBigVehicles)))
-            return;
+        RB_C_DO_CONFIG ("TrafficRandomizer", EnablePlanes, EnableHelis,
+                        EnableBoats, DisableBigVehicles, DisableLoadingTraffic);
 
         if (!Config ().EnableBoats)
             Rainbomizer::Logger::LogMessage ("Boat hater detected!!");

src/vehicles/vehicle_cacheMgr.cc

@@ -101,7 +101,9 @@ VehicleModelInfoCacheMgr::InitCache ()
         = Rainbomizer::Common::GetRainbomizerDataFile ("VehInfo.cache", "rb");
 
     if (!cacheFile || !ReadCacheFile (cacheFile))
-        return GenerateCache ();
+        GenerateCache ();
+
+    fclose (cacheFile);
 }
 
 /*******************************************************/