fix: do not cut off game sync username for some profiles

Author: DaPigGuy

src/hooks/useStore.js

@@ -26,7 +26,7 @@ import {
 import { flattenedNodes, planetJunctionsMap } from "../utils/nodes";
 import { createWithEqualityFn } from "zustand/traditional";
 import { shallow } from "zustand/shallow";
-import { getGameProfile } from "../utils/profile";
+import { getGameProfile, getUsernameFromProfile } from "../utils/profile";
 import { assignGroup } from "../utils/hash";
 
 export const useStore = createWithEqualityFn(
@@ -557,10 +557,7 @@ export const useStore = createWithEqualityFn(
 			)
 				return;
 
-			const accountUsername = gameProfile.DisplayName.slice(
-				0,
-				gameProfile.DisplayName.length - 1
-			);
+			const accountUsername = getUsernameFromProfile(gameProfile);
 			if (accountUsername !== gameSyncUsername) {
 				set({ gameSyncUsername: accountUsername });
 				updateFirestore({
@@ -656,10 +653,7 @@ export const useStore = createWithEqualityFn(
 		enableGameSync: async (accountId, platform) => {
 			const response = await getGameProfile(accountId, platform);
 			const gameProfile = response?.Results?.[0];
-			const accountUsername = gameProfile.DisplayName.slice(
-				0,
-				gameProfile.DisplayName.length - 1
-			);
+			const accountUsername = getUsernameFromProfile(gameProfile);
 
 			get().updateFirestore({
 				gameSyncUsername: accountUsername,

src/utils/profile.js

@@ -68,3 +68,13 @@ export async function getGameProfile(accountId, platform) {
 	return json;
 }
 
+export function getUsernameFromProfile(profile) {
+	if (profile.PlatformNames) {
+		// If the profile is linked to an account from a different platform,
+		// there is a platform icon character appended to the username.
+		return profile.DisplayName.slice(0, profile.DisplayName.length - 1);
+	}
+
+	return profile.DisplayName;
+}
+