Merge pull request #3095 from Parsely/fix/potential-duplicated-requests

PCH: Fix issue with potential duplicate API calls in settings and smart links

Author: vaurdan

build/content-helper/dashboard-widget.asset.php

@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-components', 'wp-data', 'wp-element', 'wp-i18n', 'wp-url'), 'version' => '3a7734d69011884c8267');
+<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-components', 'wp-data', 'wp-element', 'wp-i18n', 'wp-url'), 'version' => '8c7ccdbe52c4ca11726b');

build/content-helper/dashboard-widget.js

@@ -1 +1 @@
-<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-dom-ready', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url', 'wp-wordcount'), 'version' => 'fe15e7e38c33aff43523');
+<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-block-editor', 'wp-blocks', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-dom-ready', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url', 'wp-wordcount'), 'version' => '8f1a8e633d9114a34892');

build/content-helper/editor-sidebar.asset.php

@@ -59,13 +59,13 @@ const SettingsContext = createContext<SettingsContextType<Settings>>( {
  * // Using the useSettings hook with a specific type
  * const { settings, setSettings } = useSettings<SidebarSettings>();
  */
-export const useSettings = <T = Settings>(): SettingsContextType<T> => {
+export function useSettings<T = Settings>(): SettingsContextType<T> {
 	const context = useContext( SettingsContext );
 	if ( context === undefined ) {
 		throw new Error( 'useSettings must be used within a SettingsProvider' );
 	}
 	return context as unknown as SettingsContextType<T>;
-};
+}
 
 /**
  * Custom types for brevity and for avoiding a "type React is undefined" error.
@@ -88,14 +88,23 @@ const useSaveSettings = (
 	endpoint: string, data: Settings, deps: ReactDeps
 ): void => {
 	const isFirstRender = useRef( true );
+	const previousData = useRef<Settings>( data );
 
 	useEffect( () => {
 		// Don't save settings on the first render.
 		if ( isFirstRender.current ) {
 			isFirstRender.current = false;
+			previousData.current = data;
+			return;
+		}
+
+		// Only save if the data has actually changed.
+		if ( JSON.stringify( previousData.current ) === JSON.stringify( data ) ) {
 			return;
 		}
 
+		previousData.current = data;
+
 		apiFetch( {
 			path: '/wp-parsely/v2/settings/' + endpoint,
 			method: 'PUT',

build/content-helper/editor-sidebar.js

@@ -6,7 +6,7 @@ import { getBlockContent } from '@wordpress/blocks';
 import { Button, Notice, PanelRow } from '@wordpress/components';
 import { useDebounce } from '@wordpress/compose';
 import { select, useDispatch, useSelect } from '@wordpress/data';
-import { useEffect, useMemo, useState } from '@wordpress/element';
+import { useEffect, useMemo, useRef, useState } from '@wordpress/element';
 import { __, _n, sprintf } from '@wordpress/i18n';
 import { Icon, external } from '@wordpress/icons';
 
@@ -191,6 +191,7 @@ export const SmartLinkingPanel = ( {
 		};
 	}, [] );
 
+	const initializationRef = useRef( false );
 	/**
 	 * Handles the initialization of the Smart Linking existing links by getting the
 	 * existing smart links from the post content and the database.
@@ -207,6 +208,12 @@ export const SmartLinkingPanel = ( {
 			return;
 		}
 
+		if ( initializationRef.current ) {
+			// Return early if the component has already started initialization.
+			return;
+		}
+		initializationRef.current = true;
+
 		// Get the existing smart links from the post content.
 		const existingSmartLinks = getAllSmartLinksInPost();
 
@@ -236,12 +243,13 @@ export const SmartLinkingPanel = ( {
 			} );
 		}
 	}, [
+		permissions.SmartLinking,
+		ready,
+		postId,
 		addInboundSmartLinks,
 		addSmartLinks,
-		postId,
-		ready,
 		setIsReady,
-		permissions.SmartLinking,
+		initializationRef,
 	] );
 
 	/**