rename PollItem to reflect its current role as a facade on executor

Author: benclifford

parsl/jobs/job_status_poller.py

@@ -16,7 +16,7 @@
 logger = logging.getLogger(__name__)
 
 
-class PollItem:
+class PolledExecutorFacade:
     def __init__(self, executor: BlockProviderExecutor, dfk: Optional["parsl.dataflow.dflow.DataFlowKernel"] = None):
         self._executor = executor
         self._dfk = dfk
@@ -110,7 +110,7 @@ class JobStatusPoller(Timer):
     def __init__(self, *, strategy: Optional[str], max_idletime: float,
                  strategy_period: Union[float, int],
                  dfk: Optional["parsl.dataflow.dflow.DataFlowKernel"] = None) -> None:
-        self._poll_items = []  # type: List[PollItem]
+        self._poll_items = []  # type: List[PolledExecutorFacade]
         self.dfk = dfk
         self._strategy = Strategy(strategy=strategy,
                                   max_idletime=max_idletime)
@@ -121,7 +121,7 @@ def poll(self) -> None:
         self._run_error_handlers(self._poll_items)
         self._strategy.strategize(self._poll_items)
 
-    def _run_error_handlers(self, status: List[PollItem]) -> None:
+    def _run_error_handlers(self, status: List[PolledExecutorFacade]) -> None:
         for es in status:
             es.executor.handle_errors(es.status)
 
@@ -134,5 +134,5 @@ def add_executors(self, executors: Sequence[BlockProviderExecutor]) -> None:
         for executor in executors:
             if executor.status_polling_interval > 0:
                 logger.debug("Adding executor {}".format(executor.label))
-                self._poll_items.append(PollItem(executor, self.dfk))
+                self._poll_items.append(PolledExecutorFacade(executor, self.dfk))
         self._strategy.add_executors(executors)

parsl/jobs/strategy.py

@@ -146,7 +146,7 @@ def add_executors(self, executors: Sequence[ParslExecutor]) -> None:
         for executor in executors:
             self.executors[executor.label] = {'idle_since': None}
 
-    def _strategy_init_only(self, status_list: List[jsp.PollItem]) -> None:
+    def _strategy_init_only(self, status_list: List[jsp.PolledExecutorFacade]) -> None:
         """Scale up to init_blocks at the start, then nothing more.
         """
         for exec_status in status_list:
@@ -158,10 +158,10 @@ def _strategy_init_only(self, status_list: List[jsp.PollItem]) -> None:
             else:
                 logger.debug("strategy_init_only: doing nothing")
 
-    def _strategy_simple(self, status_list: List[jsp.PollItem]) -> None:
+    def _strategy_simple(self, status_list: List[jsp.PolledExecutorFacade]) -> None:
         self._general_strategy(status_list, strategy_type='simple')
 
-    def _strategy_htex_auto_scale(self, status_list: List[jsp.PollItem]) -> None:
+    def _strategy_htex_auto_scale(self, status_list: List[jsp.PolledExecutorFacade]) -> None:
         """HTEX specific auto scaling strategy
 
         This strategy works only for HTEX. This strategy will scale out by