Skip to content

Commit 2c4e78a

Browse files
committed
close method for api
1 parent 18a802f commit 2c4e78a

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

parsl/dataflow/dflow.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1202,6 +1202,7 @@ def cleanup(self) -> None:
12021202

12031203
self.log_task_states()
12041204

1205+
# TODO: do this in the basic memoizer
12051206
# Checkpointing takes priority over the rest of the tasks
12061207
# checkpoint if any valid checkpoint method is specified
12071208
if self.checkpoint_mode is not None:
@@ -1214,6 +1215,10 @@ def cleanup(self) -> None:
12141215
logger.info("Stopping checkpoint timer")
12151216
self._checkpoint_timer.close()
12161217

1218+
logger.info("Closing memoizer")
1219+
self.memoizer.close()
1220+
logger.info("Closed memoizer")
1221+
12171222
# Send final stats
12181223
self.usage_tracker.send_end_message()
12191224
self.usage_tracker.close()

parsl/dataflow/memoization.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,9 @@ def checkpoint(self, tasks: Sequence[TaskRecord]) -> None:
130130
def check_memo(self, task: TaskRecord) -> Optional[Future[Any]]:
131131
raise NotImplementedError
132132

133+
def close(self) -> None:
134+
raise NotImplementedError
135+
133136

134137
class BasicMemoizer(Memoizer):
135138
"""Memoizer is responsible for ensuring that identical work is not repeated.

0 commit comments

Comments
 (0)