Remove deprecated max_worker (#3605)

Any workflows that still use max_worker will no longer simply get a warning message but still work. Users will need to change any scripts to use max_workers_per_node. (But they've had six months of warnings to do the deed!)

Author: khk-globus

parsl/executors/high_throughput/executor.py

@@ -199,9 +199,6 @@ class HighThroughputExecutor(BlockProviderExecutor, RepresentationMixin, UsageIn
         will check the available memory at startup and limit the number of workers such that
         the there's sufficient memory for each worker. Default: None
 
-    max_workers : int
-        Deprecated. Please use max_workers_per_node instead.
-
     max_workers_per_node : int
         Caps the number of workers launched per node. Default: None
 
@@ -239,7 +236,6 @@ def __init__(self,
                  worker_debug: bool = False,
                  cores_per_worker: float = 1.0,
                  mem_per_worker: Optional[float] = None,
-                 max_workers: Optional[Union[int, float]] = None,
                  max_workers_per_node: Optional[Union[int, float]] = None,
                  cpu_affinity: str = 'none',
                  available_accelerators: Union[int, Sequence[str]] = (),
@@ -272,9 +268,7 @@ def __init__(self,
         else:
             self.all_addresses = ','.join(get_all_addresses())
 
-        if max_workers:
-            self._warn_deprecated("max_workers", "max_workers_per_node")
-        self.max_workers_per_node = max_workers_per_node or max_workers or float("inf")
+        self.max_workers_per_node = max_workers_per_node or float("inf")
 
         mem_slots = self.max_workers_per_node
         cpu_slots = self.max_workers_per_node
@@ -335,16 +329,6 @@ def _warn_deprecated(self, old: str, new: str):
             stacklevel=2
         )
 
-    @property
-    def max_workers(self):
-        self._warn_deprecated("max_workers", "max_workers_per_node")
-        return self.max_workers_per_node
-
-    @max_workers.setter
-    def max_workers(self, val: Union[int, float]):
-        self._warn_deprecated("max_workers", "max_workers_per_node")
-        self.max_workers_per_node = val
-
     @property
     def logdir(self):
         return "{}/{}".format(self.run_dir, self.label)

parsl/tests/site_tests/README.rst

@@ -46,27 +46,28 @@ Adding a new site
    1. Specialized python builds for the system (for eg, Summit)
    2. Anaconda available via modules
    3. User's conda installation
-* Add a new block to `conda_setup.sh` that installs a fresh environment and writes out
-  the activation commands to `~/setup_parsl_test_env.sh`
-* Add a site config to `parsl/tests/configs/<SITE.py>` and add your local user options
-  to `parsl/tests/configs/local_user_opts.py`. For eg, `here's mine<https://gist.github.com/yadudoc/b71765284d2db0706c4f43605dd8b8d6>`_
-  Make sure that the site config uses the `fresh_config` pattern.
+* Add a new block to ``conda_setup.sh`` that installs a fresh environment and writes out
+  the activation commands to ``~/setup_parsl_test_env.sh``
+* Add a site config to ``parsl/tests/configs/<SITE.py>`` and add your local user options
+  to ``parsl/tests/configs/local_user_opts.py``. For example,
+  `here's mine<https://gist.github.com/yadudoc/b71765284d2db0706c4f43605dd8b8d6>`_
+  Make sure that the site config uses the ``fresh_config`` pattern.
   Please ensure that the site config uses:
-    * max_workers = 1
-    * init_blocks = 1
-    * min_blocks = 0
+    * ``max_workers_per_node = 1``
+    * ``init_blocks = 1``
+    * ``min_blocks = 0``
 
-* Add this site config to `parsl/tests/site_tests/site_config_selector.py`
-* Reinstall parsl, using `pip install .`
-* Test a single test: `python3 test_site.py -d` to confirm that the site works correctly.
-* Once tests are passing run the whole site_test with `make site_test`
+* Add this site config to ``parsl/tests/site_tests/site_config_selector.py``
+* Reinstall parsl, using ``pip install .``
+* Test a single test: ``python3 test_site.py -d`` to confirm that the site works correctly.
+* Once tests are passing run the whole site_test with ``make site_test``
 
 
 Shared filesystem option
 ------------------------
 
-There is a new env variable "SHARED_FS_OPTIONS" to pass markers to pytest to skip certain tests.
+There is a new env variable ``SHARED_FS_OPTIONS`` to pass markers to pytest to skip certain tests.
 
 When there's a shared-FS, the default NoOpStaging works. However, when there's no shared-FS some tests
 that uses File objects require a staging provider (eg. rsync). These tests can be turned off with
-`-k "not staging_required"`
+``-k "not staging_required"``

parsl/tests/test_htex/test_htex.py

@@ -126,18 +126,6 @@ def kill_interchange(*args, **kwargs):
         assert "HighThroughputExecutor has not started" in caplog.text
 
 
-@pytest.mark.local
-def test_max_workers_per_node():
-    with pytest.warns(DeprecationWarning) as record:
-        htex = HighThroughputExecutor(max_workers_per_node=1, max_workers=2)
-
-    warning_msg = "max_workers is deprecated"
-    assert any(warning_msg in str(warning.message) for warning in record)
-
-    # Ensure max_workers_per_node takes precedence
-    assert htex.max_workers_per_node == htex.max_workers == 1
-
-
 @pytest.mark.local
 @pytest.mark.parametrize("cmd", (None, "custom-launch-cmd"))
 def test_htex_worker_pool_launch_cmd(cmd: Optional[str]):

parsl/tests/test_mpi_apps/test_mpiex.py

@@ -43,7 +43,7 @@ def test_init():
 
     new_kwargs = {'max_workers_per_block', 'mpi_launcher'}
     excluded_kwargs = {'available_accelerators', 'cores_per_worker', 'max_workers_per_node',
-                       'mem_per_worker', 'cpu_affinity', 'max_workers', 'manager_selector'}
+                       'mem_per_worker', 'cpu_affinity', 'manager_selector'}
 
     # Get the kwargs from both HTEx and MPIEx
     htex_kwargs = set(signature(HighThroughputExecutor.__init__).parameters)

parsl/tests/test_scaling/test_scale_down_htex_auto_scale.py

@@ -23,7 +23,7 @@ def local_config():
                 poll_period=100,
                 label="htex_local",
                 address="127.0.0.1",
-                max_workers=1,
+                max_workers_per_node=1,
                 encrypted=True,
                 provider=LocalProvider(
                     channel=LocalChannel(),

parsl/tests/test_scaling/test_scale_down_htex_unregistered.py

@@ -27,7 +27,7 @@ def local_config():
                 poll_period=100,
                 label="htex_local",
                 address="127.0.0.1",
-                max_workers=1,
+                max_workers_per_node=1,
                 encrypted=True,
                 launch_cmd="sleep inf",
                 provider=LocalProvider(