Skip to content

Commit 4ba0382

Browse files
authored
Formalize required argument (#3768)
`--addresses` is de facto expected to be specified, and breaks if not specified. Formalize that expectation. # Changed Behaviour No changed behaviour. ## Type of change - Code maintenance/cleanup
1 parent f20ab8e commit 4ba0382

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

parsl/executors/high_throughput/process_worker_pool.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -828,7 +828,7 @@ def strategyorlist(s: str):
828828
parser.add_argument(
829829
"-a",
830830
"--addresses",
831-
default='',
831+
required=True,
832832
help="Comma separated list of addresses at which the interchange could be reached",
833833
)
834834
parser.add_argument(

parsl/tests/unit/executors/high_throughput/test_process_worker_pool.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"--cpu-affinity",
1818
"--result_port",
1919
"--task_port",
20+
"--addresses",
2021
)
2122

2223

@@ -62,6 +63,7 @@ def test_arg_parser_validates_cpu_affinity(valid, val):
6263
reqd_args.extend(("--cert_dir", "/some/path"))
6364
reqd_args.extend(("--result_port", "123"))
6465
reqd_args.extend(("--task_port", "123"))
66+
reqd_args.extend(("--addresses", "asdf"))
6567
reqd_args.extend(("--cpu-affinity", val))
6668

6769
p = process_worker_pool.get_arg_parser()

0 commit comments

Comments
 (0)