Skip to content

Commit 5f5aa46

Browse files
authored
Remove Channels.abspath that is unused (#3652)
1 parent bcea1fa commit 5f5aa46

File tree

3 files changed

+1
-32
lines changed

3 files changed

+1
-32
lines changed

parsl/channels/base.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -120,14 +120,3 @@ def isdir(self, path: str) -> bool:
120120
Path of directory to check.
121121
"""
122122
pass
123-
124-
@abstractmethod
125-
def abspath(self, path: str) -> str:
126-
"""Return the absolute path.
127-
128-
Parameters
129-
----------
130-
path : str
131-
Path for which the absolute path will be returned.
132-
"""
133-
pass

parsl/channels/local/local.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -145,22 +145,12 @@ def makedirs(self, path, mode=0o700, exist_ok=False):
145145

146146
return os.makedirs(path, mode, exist_ok)
147147

148-
def abspath(self, path):
149-
"""Return the absolute path.
150-
151-
Parameters
152-
----------
153-
path : str
154-
Path for which the absolute path will be returned.
155-
"""
156-
return os.path.abspath(path)
157-
158148
@property
159149
def script_dir(self):
160150
return self._script_dir
161151

162152
@script_dir.setter
163153
def script_dir(self, value):
164154
if value is not None:
165-
value = self.abspath(value)
155+
value = os.path.abspath(value)
166156
self._script_dir = value

parsl/channels/ssh/ssh.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -287,16 +287,6 @@ def makedirs(self, path, mode=0o700, exist_ok=False):
287287
self.execute_wait('mkdir -p {}'.format(path))
288288
self._valid_sftp_client().chmod(path, mode)
289289

290-
def abspath(self, path):
291-
"""Return the absolute path on the remote side.
292-
293-
Parameters
294-
----------
295-
path : str
296-
Path for which the absolute path will be returned.
297-
"""
298-
return self._valid_sftp_client().normalize(path)
299-
300290
@property
301291
def script_dir(self):
302292
return self._script_dir

0 commit comments

Comments
 (0)