Skip to content

Commit 8afdd2f

Browse files
committed
add a todo on checkpoint policy position
1 parent a2e3804 commit 8afdd2f

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

parsl/dataflow/dflow.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,8 @@ def __init__(self, config: Config) -> None:
157157
self.monitoring.send((MessageType.WORKFLOW_INFO,
158158
workflow_info))
159159

160+
# TODO: this configuration should become part of the particular memoizer code
161+
# - this is a checkpoint-implementation-specific parameter
160162
if config.checkpoint_files is not None:
161163
checkpoint_files = config.checkpoint_files
162164
elif config.checkpoint_files is None and config.checkpoint_mode is not None:
@@ -193,6 +195,10 @@ def __init__(self, config: Config) -> None:
193195
self.add_executors(config.executors)
194196
self.add_executors([parsl_internal_executor])
195197

198+
# TODO: these checkpoint modes should move into the memoizer implementation
199+
# they're (probably?) checkpointer specific: for example the sqlite3-pure-memoizer
200+
# doesn't have a notion of building up an in-memory checkpoint table that needs to be
201+
# flushed on a separate policy
196202
if self.checkpoint_mode == "periodic":
197203
if config.checkpoint_period is None:
198204
raise ConfigurationError("Checkpoint period must be specified with periodic checkpoint mode")

0 commit comments

Comments
 (0)