Skip to content

Commit 9101815

Browse files
authored
Remove bash app exception return code report that is constant None (#4008)
There is no code path where this value gets set and then ends up in the exception block, and this code misleading leads a reader to think the unix return code will be reported here. The unix return code is actually reported for failing apps a few lines later with a BashExitFailure exception. # Changed Behaviour The text "with returncode: None" no longer appears on this exception. ## Type of change - Update to human readable text: Documentation/error messages/comments
1 parent 96a6a01 commit 9101815

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

parsl/app/bash.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def open_std_fd(fdname):
8888
raise pe.AppTimeout(f"App {func_name} exceeded walltime: {timeout} seconds")
8989

9090
except Exception as e:
91-
raise pe.AppException(f"App {func_name} caught exception with returncode: {returncode}", e)
91+
raise pe.AppException(f"App {func_name} caught exception", e)
9292

9393
if returncode != 0:
9494
raise pe.BashExitFailure(func_name, proc.returncode)

0 commit comments

Comments
 (0)