Skip to content

Commit a65b5b8

Browse files
authored
Remove unneeded threads in ZMQ/UDP routers (#3797)
Before this PR, the ZMQ/UDP router main threads only launched the receiver threads and then waiting for them to terminate. There is no need for separate threads for this. # Changed Behaviour none ## Type of change - Code maintenance/cleanup
1 parent 0e6c2f3 commit a65b5b8

File tree

2 files changed

+2
-22
lines changed

2 files changed

+2
-22
lines changed

parsl/monitoring/radios/udp_router.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import os
66
import pickle
77
import socket
8-
import threading
98
import time
109
from multiprocessing.synchronize import Event
1110
from typing import Optional
@@ -87,16 +86,7 @@ def __init__(self,
8786

8887
@wrap_with_logs(target="monitoring_router")
8988
def start(self) -> None:
90-
self.logger.info("Starting UDP listener thread")
91-
udp_radio_receiver_thread = threading.Thread(target=self.start_udp_listener, daemon=True)
92-
udp_radio_receiver_thread.start()
93-
94-
self.logger.info("Joining on UDP listener thread")
95-
udp_radio_receiver_thread.join()
96-
self.logger.info("Joined on both ZMQ and UDP listener threads")
97-
98-
@wrap_with_logs(target="monitoring_router")
99-
def start_udp_listener(self) -> None:
89+
self.logger.info("Starting UDP listener")
10090
try:
10191
while not self.exit_event.is_set():
10292
try:

parsl/monitoring/radios/zmq_router.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import logging
44
import multiprocessing.queues as mpq
55
import os
6-
import threading
76
import time
87
from multiprocessing.synchronize import Event
98
from typing import Tuple
@@ -79,16 +78,7 @@ def __init__(self,
7978

8079
@wrap_with_logs(target="monitoring_router")
8180
def start(self) -> None:
82-
self.logger.info("Starting ZMQ listener thread")
83-
zmq_radio_receiver_thread = threading.Thread(target=self.start_zmq_listener, daemon=True)
84-
zmq_radio_receiver_thread.start()
85-
86-
self.logger.info("Joining on ZMQ listener thread")
87-
zmq_radio_receiver_thread.join()
88-
self.logger.info("Joined on ZMQ listener threads")
89-
90-
@wrap_with_logs(target="monitoring_router")
91-
def start_zmq_listener(self) -> None:
81+
self.logger.info("Starting ZMQ listener")
9282
try:
9383
while not self.exit_event.is_set():
9484
try:

0 commit comments

Comments
 (0)