File tree Expand file tree Collapse file tree 1 file changed +6
-0
lines changed Expand file tree Collapse file tree 1 file changed +6
-0
lines changed Original file line number Diff line number Diff line change @@ -165,6 +165,8 @@ def __init__(self, config: Config) -> None:
165165 self .monitoring_radio .send ((MessageType .WORKFLOW_INFO ,
166166 workflow_info ))
167167
168+ # TODO: this configuration should become part of the particular memoizer code
169+ # - this is a checkpoint-implementation-specific parameter
168170 if config .checkpoint_files is not None :
169171 checkpoint_files = config .checkpoint_files
170172 elif config .checkpoint_files is None and config .checkpoint_mode is not None :
@@ -202,6 +204,10 @@ def __init__(self, config: Config) -> None:
202204 self .add_executors (config .executors )
203205 self .add_executors ([parsl_internal_executor ])
204206
207+ # TODO: these checkpoint modes should move into the memoizer implementation
208+ # they're (probably?) checkpointer specific: for example the sqlite3-pure-memoizer
209+ # doesn't have a notion of building up an in-memory checkpoint table that needs to be
210+ # flushed on a separate policy
205211 if self .checkpoint_mode == "periodic" :
206212 if config .checkpoint_period is None :
207213 raise ConfigurationError ("Checkpoint period must be specified with periodic checkpoint mode" )
You can’t perform that action at this time.
0 commit comments